Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1181353003: Revert of Revert of Abstract //content-level dependencies out of InMemoryURLIndex (Closed)

Created:
5 years, 6 months ago by paulmeyer
Modified:
5 years, 6 months ago
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Abstract //content-level dependencies out of InMemoryURLIndex (patchset #1 id:1 of https://codereview.chromium.org/1184923006/) Reason for revert: This revert broke other things. Reverting the revert. Original issue's description: > Revert of Abstract //content-level dependencies out of InMemoryURLIndex (patchset #5 id:100001 of https://codereview.chromium.org/1186103002/) > > Reason for revert: > Speculative revert to fix the Windows unit_test failures. > > Original issue's description: > > Abstract //content-level dependencies out of InMemoryURLIndex > > > > It now takes a base::SequencedWorkerPool and a set of client schemes to > > whitelist in its constructor. > > > > BUG=371538 > > > > TBR=phajdan.jr > > > > Committed: https://crrev.com/a6da40f8abbf44f8dab8db59a425b85c1db44376 > > Cr-Commit-Position: refs/heads/master@{#334799} > > TBR=pkasting@chromium.org,phajdan.jr@chromium.org,blundell@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=371538 > > Committed: https://crrev.com/9d9c3c5655eff730578dc1e9524139ccd60fdb98 > Cr-Commit-Position: refs/heads/master@{#334866} TBR=pkasting@chromium.org,phajdan.jr@chromium.org,blundell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371538 Committed: https://crrev.com/b834d85d0e2c3152a794d11fab93542cdc745c49 Cr-Commit-Position: refs/heads/master@{#334872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -41 lines) Patch
M chrome/browser/autocomplete/in_memory_url_index.h View 8 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index.cc View 9 chunks +28 lines, -24 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_factory.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 9 chunks +18 lines, -8 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
paulmeyer
Created Revert of Revert of Abstract //content-level dependencies out of InMemoryURLIndex
5 years, 6 months ago (2015-06-17 18:02:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181353003/1
5 years, 6 months ago (2015-06-17 18:02:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 18:04:29 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 18:05:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b834d85d0e2c3152a794d11fab93542cdc745c49
Cr-Commit-Position: refs/heads/master@{#334872}

Powered by Google App Engine
This is Rietveld 408576698