OLD | NEW |
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. | 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. |
6 #if defined(TARGET_ARCH_ARM) | 6 #if defined(TARGET_ARCH_ARM) |
7 | 7 |
8 #include "vm/intermediate_language.h" | 8 #include "vm/intermediate_language.h" |
9 | 9 |
10 #include "vm/dart_entry.h" | 10 #include "vm/dart_entry.h" |
(...skipping 1288 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1299 Register field_reg = needs_field_temp_reg ? | 1299 Register field_reg = needs_field_temp_reg ? |
1300 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister; | 1300 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister; |
1301 | 1301 |
1302 Label ok, fail_label; | 1302 Label ok, fail_label; |
1303 | 1303 |
1304 Label* deopt = compiler->is_optimizing() ? | 1304 Label* deopt = compiler->is_optimizing() ? |
1305 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL; | 1305 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL; |
1306 | 1306 |
1307 Label* fail = (deopt != NULL) ? deopt : &fail_label; | 1307 Label* fail = (deopt != NULL) ? deopt : &fail_label; |
1308 | 1308 |
| 1309 const bool ok_is_fall_through = (deopt != NULL); |
| 1310 |
1309 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) { | 1311 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) { |
1310 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) { | 1312 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) { |
1311 // Currently we can't have different location summaries for optimized | 1313 // Currently we can't have different location summaries for optimized |
1312 // and non-optimized code. So instead we manually pick up a register | 1314 // and non-optimized code. So instead we manually pick up a register |
1313 // that is known to be free because we know how non-optimizing compiler | 1315 // that is known to be free because we know how non-optimizing compiler |
1314 // allocates registers. | 1316 // allocates registers. |
1315 field_reg = R2; | 1317 field_reg = R2; |
1316 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg)); | 1318 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg)); |
1317 } | 1319 } |
1318 | 1320 |
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1483 // Destroy value_cid_reg (safe because we are finished with it). | 1485 // Destroy value_cid_reg (safe because we are finished with it). |
1484 __ ldr(value_cid_reg, | 1486 __ ldr(value_cid_reg, |
1485 FieldAddress(value_reg, TypedData::length_offset())); | 1487 FieldAddress(value_reg, TypedData::length_offset())); |
1486 __ str(value_cid_reg, field_length_operand); | 1488 __ str(value_cid_reg, field_length_operand); |
1487 } else { | 1489 } else { |
1488 __ LoadImmediate(IP, Smi::RawValue(Field::kNoFixedLength)); | 1490 __ LoadImmediate(IP, Smi::RawValue(Field::kNoFixedLength)); |
1489 __ str(IP, field_length_operand); | 1491 __ str(IP, field_length_operand); |
1490 } | 1492 } |
1491 } | 1493 } |
1492 } | 1494 } |
| 1495 if (!ok_is_fall_through) { |
| 1496 __ b(&ok); |
| 1497 } |
1493 | 1498 |
1494 if (deopt == NULL) { | 1499 if (deopt == NULL) { |
1495 ASSERT(!compiler->is_optimizing()); | 1500 ASSERT(!compiler->is_optimizing()); |
1496 __ b(&ok); | |
1497 __ Bind(fail); | 1501 __ Bind(fail); |
1498 | 1502 |
1499 __ ldr(IP, FieldAddress(field_reg, Field::guarded_cid_offset())); | 1503 __ ldr(IP, FieldAddress(field_reg, Field::guarded_cid_offset())); |
1500 __ CompareImmediate(IP, kDynamicCid); | 1504 __ CompareImmediate(IP, kDynamicCid); |
1501 __ b(&ok, EQ); | 1505 __ b(&ok, EQ); |
1502 | 1506 |
1503 __ Push(field_reg); | 1507 __ Push(field_reg); |
1504 __ Push(value_reg); | 1508 __ Push(value_reg); |
1505 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2); | 1509 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2); |
1506 __ Drop(2); // Drop the field and the value. | 1510 __ Drop(2); // Drop the field and the value. |
1507 } | 1511 } |
1508 } else { | 1512 } else { |
1509 ASSERT(compiler->is_optimizing()); | 1513 ASSERT(compiler->is_optimizing()); |
1510 ASSERT(deopt != NULL); | 1514 ASSERT(deopt != NULL); |
| 1515 ASSERT(ok_is_fall_through); |
1511 // Field guard class has been initialized and is known. | 1516 // Field guard class has been initialized and is known. |
1512 if (field_reg != kNoRegister) { | 1517 if (field_reg != kNoRegister) { |
1513 __ LoadObject(field_reg, Field::ZoneHandle(field().raw())); | 1518 __ LoadObject(field_reg, Field::ZoneHandle(field().raw())); |
1514 } | 1519 } |
1515 if (value_cid == kDynamicCid) { | 1520 if (value_cid == kDynamicCid) { |
1516 // Field's guarded class id is fixed by value's class id is not known. | 1521 // Field's guarded class id is fixed by value's class id is not known. |
1517 __ tst(value_reg, ShifterOperand(kSmiTagMask)); | 1522 __ tst(value_reg, ShifterOperand(kSmiTagMask)); |
1518 | 1523 |
1519 if (field_cid != kSmiCid) { | 1524 if (field_cid != kSmiCid) { |
1520 __ b(fail, EQ); | 1525 __ b(fail, EQ); |
(...skipping 3300 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
4821 compiler->GenerateCall(token_pos(), | 4826 compiler->GenerateCall(token_pos(), |
4822 &label, | 4827 &label, |
4823 PcDescriptors::kOther, | 4828 PcDescriptors::kOther, |
4824 locs()); | 4829 locs()); |
4825 __ Drop(2); // Discard type arguments and receiver. | 4830 __ Drop(2); // Discard type arguments and receiver. |
4826 } | 4831 } |
4827 | 4832 |
4828 } // namespace dart | 4833 } // namespace dart |
4829 | 4834 |
4830 #endif // defined TARGET_ARCH_ARM | 4835 #endif // defined TARGET_ARCH_ARM |
OLD | NEW |