google_apis/gcm/engine/fake_connection_factory.cc - Issue 118133003: [GCM] Add heartbeat manager and reconnection logic due to heartbeat failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/fake_connection_factory.cc

Issue 118133003: [GCM] Add heartbeat manager and reconnection logic due to heartbeat failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Jian's comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « google_apis/gcm/engine/connection_handler_impl_unittest.cc ('k') | google_apis/gcm/engine/fake_connection_handler.h » ('j') | google_apis/gcm/engine/heartbeat_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/fake_connection_factory.cc

diff --git a/google_apis/gcm/engine/fake_connection_factory.cc b/google_apis/gcm/engine/fake_connection_factory.cc

index 93e66cb6ce491007611412a05f9c99f87c4ebda2..084ff663591522092f504e0e25d1425c87821ba8 100644

--- a/google_apis/gcm/engine/fake_connection_factory.cc

+++ b/google_apis/gcm/engine/fake_connection_factory.cc

@@ -32,7 +32,7 @@ ConnectionHandler* FakeConnectionFactory::GetConnectionHandler() const {

void FakeConnectionFactory::Connect() {

mcs_proto::LoginRequest login_request;

request_builder_.Run(&login_request);

- connection_handler_->Init(login_request, scoped_ptr<net::StreamSocket>());

+ connection_handler_->Init(login_request, NULL);

}

bool FakeConnectionFactory::IsEndpointReachable() const {