google_apis/gcm/engine/connection_handler_impl.h - Issue 118133003: [GCM] Add heartbeat manager and reconnection logic due to heartbeat failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_handler_impl.h

Issue 118133003: [GCM] Add heartbeat manager and reconnection logic due to heartbeat failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « google_apis/gcm/engine/connection_handler.h ('k') | google_apis/gcm/engine/connection_handler_impl.cc » ('j') | google_apis/gcm/engine/connection_handler_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/connection_handler_impl.h

diff --git a/google_apis/gcm/engine/connection_handler_impl.h b/google_apis/gcm/engine/connection_handler_impl.h

index 110cdcdddda51d7e228fb30bb73fef25799dc68e..c4efe66f7d31620be609804148618de6061180f3 100644

--- a/google_apis/gcm/engine/connection_handler_impl.h

+++ b/google_apis/gcm/engine/connection_handler_impl.h

@@ -34,7 +34,7 @@ class GCM_EXPORT ConnectionHandlerImpl : public ConnectionHandler {

// ConnectionHandler implementation.

virtual void Init(const mcs_proto::LoginRequest& login_request,

- scoped_ptr<net::StreamSocket> socket) OVERRIDE;

+ net::StreamSocket* socket) OVERRIDE;

virtual bool CanSendMessage() const OVERRIDE;

virtual void SendMessage(const google::protobuf::MessageLite& message)

OVERRIDE;

@@ -96,7 +96,7 @@ class GCM_EXPORT ConnectionHandlerImpl : public ConnectionHandler {

base::OneShotTimer<ConnectionHandlerImpl> read_timeout_timer_;

// This connection's socket and the input/output streams attached to it.

- scoped_ptr<net::StreamSocket> socket_;

+ net::StreamSocket* socket_;

scoped_ptr<SocketInputStream> input_stream_;

scoped_ptr<SocketOutputStream> output_stream_;