Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: google_apis/gcm/engine/heartbeat_manager.cc

Issue 118133003: [GCM] Add heartbeat manager and reconnection logic due to heartbeat failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Jian's comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "google_apis/gcm/engine/heartbeat_manager.h"
6
7 #include "google_apis/gcm/protocol/mcs.pb.h"
8 #include "net/base/network_change_notifier.h"
9
10 namespace gcm {
11
12 namespace {
13 // The default heartbeat when on a mobile or unknown network .
14 const int64 kCellHeartbeatDefaultMs = 1000 * 60 * 15; // 15 minutes.
15 // The default heartbeat when on WiFi (also used for ethernet).
16 const int64 kWifiHeartbeatDefaultMs = 1000 * 60 * 28; // 28 minutes.
fgorski 2013/12/26 23:04:09 It seems that you've reverted some of the changes
Nicolas Zea 2013/12/26 23:09:06 Done.
17 // The default heartbeat ack interval.
18 const int64 kHeartbeatAckDefaultMs = 1000 * 60 * 1; // 1 minute.
19 } // namespace
20
21 HeartbeatManager::HeartbeatManager()
22 : waiting_for_ack_(false),
23 heartbeat_interval_ms_(0),
24 server_interval_ms_(0),
25 heartbeat_timer_(true /* retain user task */,
26 false /* not repeating */),
27 weak_ptr_factory_(this) {}
28
29 HeartbeatManager::~HeartbeatManager() {}
30
31 void HeartbeatManager::Start(
32 const base::Closure& send_heartbeat_callback,
33 const base::Closure& trigger_reconnect_callback) {
fgorski 2013/12/26 23:04:09 ditto
Nicolas Zea 2013/12/26 23:09:06 Done.
34 send_heartbeat_callback_ = send_heartbeat_callback;
35 trigger_reconnect_callback_ = trigger_reconnect_callback;
36
37 // Kicks off the timer.
38 waiting_for_ack_ = false;
39 RestartTimer();
40 }
41
42 void HeartbeatManager::Stop() {
43 heartbeat_timer_.Stop();
44 waiting_for_ack_ = false;
45 }
46
47 void HeartbeatManager::OnHeartbeatAcked() {
48 if (!heartbeat_timer_.IsRunning())
49 return;
50
51 DCHECK(!send_heartbeat_callback_.is_null());
52 DCHECK(!trigger_reconnect_callback_.is_null());
53 waiting_for_ack_ = false;
54 RestartTimer();
55 }
56
57 void HeartbeatManager::UpdateHeartbeatConfig(
58 const mcs_proto::HeartbeatConfig& config) {
59 if (!config.IsInitialized() ||
60 !config.has_interval_ms() ||
61 config.interval_ms() <= 0) {
62 return;
63 }
64 DVLOG(1) << "Updating heartbeat interval to " << config.interval_ms();
65 server_interval_ms_ = config.interval_ms();
66 }
67
68 base::TimeTicks HeartbeatManager::GetNextHeartbeatTime() const {
69 if (heartbeat_timer_.IsRunning())
70 return heartbeat_timer_.desired_run_time();
71 else
72 return base::TimeTicks();
73 }
74
75 void HeartbeatManager::OnHeartbeatTriggered() {
76 if (waiting_for_ack_) {
77 LOG(WARNING) << "Lost connection to MCS, reconnecting.";
78 Stop();
79 trigger_reconnect_callback_.Run();
80 return;
81 }
82
83 waiting_for_ack_ = true;
84 RestartTimer();
85 send_heartbeat_callback_.Run();
86 }
87
88 void HeartbeatManager::RestartTimer() {
89 if (!waiting_for_ack_) {
90 // Recalculate the timer interval based network type.
91 if (server_interval_ms_ != 0) {
92 // If a server interval is set, it overrides any local one.
93 heartbeat_interval_ms_ = server_interval_ms_;
94 } else if (net::NetworkChangeNotifier::GetConnectionType() ==
95 net::NetworkChangeNotifier::CONNECTION_WIFI ||
96 net::NetworkChangeNotifier::GetConnectionType() ==
97 net::NetworkChangeNotifier::CONNECTION_ETHERNET) {
98 heartbeat_interval_ms_ = kWifiHeartbeatDefaultMs;
99 } else {
100 // For unknown connections, use the shorter cellular heartbeat interval.
101 heartbeat_interval_ms_ = kCellHeartbeatDefaultMs;
102 }
103 DVLOG(1) << "Sending next heartbeat in "
104 << heartbeat_interval_ms_ << " ms.";
105 } else {
106 heartbeat_interval_ms_ = kHeartbeatAckDefaultMs;
107 DVLOG(1) << "Resetting timer for ack with "
108 << heartbeat_interval_ms_ << " ms interval.";
109 }
110 heartbeat_timer_.Start(FROM_HERE,
111 base::TimeDelta::FromMilliseconds(
112 heartbeat_interval_ms_),
113 base::Bind(&HeartbeatManager::OnHeartbeatTriggered,
114 weak_ptr_factory_.GetWeakPtr()));
115 }
116
117 } // namespace gcm
OLDNEW
« no previous file with comments | « google_apis/gcm/engine/heartbeat_manager.h ('k') | google_apis/gcm/engine/heartbeat_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698