base/metrics/histogram_base.h - Issue 1181293005: Optimize memory use of registered histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.h

Issue 1181293005: Optimize memory use of registered histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_base.h

diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h

index 006395b1f2939707af6c52b8df935413cdf139b7..bdc052eff2d2b8be16d6dbbac3683f4d062c74db 100644

--- a/base/metrics/histogram_base.h

+++ b/base/metrics/histogram_base.h

@@ -92,7 +92,7 @@ class BASE_EXPORT HistogramBase {

explicit HistogramBase(const std::string& name);

virtual ~HistogramBase();

- std::string histogram_name() const { return histogram_name_; }

+ const std::string& histogram_name() const { return histogram_name_; }

// Comapres |name| to the histogram name and triggers a DCHECK if they do not

// match. This is a helper function used by histogram macros, which results in

« no previous file with comments | « no previous file | base/metrics/statistics_recorder.h » ('j') | no next file with comments »