Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 1181283005: Remove unnecessary image packing code. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unnecessary image packing code. Basically we only need to unpack images if 1) it's from HTML elements, where the colors are either RGBA8 or BGRA8 (used by skia); or 2) it has color and alpha (code might ask for premultiply or unmultiply alpha) BUG=497352 TEST=webgl conformance tests R=kbr@chromium.org,bajones@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197300

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -169 lines) Patch
M Source/platform/graphics/cpu/arm/WebGLImageConversionNEON.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
M Source/platform/graphics/gpu/WebGLImageConversion.cpp View 6 chunks +0 lines, -137 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Zhenyao Mo
bajones, kbr: could you please take a look at your earliest convenience? I have quite ...
4 years, 10 months ago (2015-06-17 20:40:59 UTC) #1
Zhenyao Mo
Tested with WebGL conformance tests 1.0.4 on Linux, no regression, so these codes are truly ...
4 years, 10 months ago (2015-06-17 20:41:30 UTC) #2
Zhenyao Mo
Not yet, a lot more code can be deleted.
4 years, 10 months ago (2015-06-17 21:04:06 UTC) #3
Zhenyao Mo
My apology, but the CL is good as is. It turned out the extra code ...
4 years, 10 months ago (2015-06-17 22:23:59 UTC) #4
bajones
On 2015/06/17 22:23:59, Zhenyao Mo wrote: > My apology, but the CL is good as ...
4 years, 10 months ago (2015-06-17 22:25:31 UTC) #5
Ken Russell (switch to Gerrit)
Excellent cleanup. LGTM
4 years, 10 months ago (2015-06-17 23:44:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181283005/20001
4 years, 10 months ago (2015-06-17 23:45:32 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 01:14:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197300

Powered by Google App Engine
This is Rietveld 408576698