extensions/browser/guest_view/web_view/web_view_guest_delegate.h - Issue 1181263007: WebView context menu cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest_delegate.h

Issue 1181263007: WebView context menu cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment by fsamuel@. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest_delegate.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest_delegate.h b/extensions/browser/guest_view/web_view/web_view_guest_delegate.h

index 1fbabf8ea33f18fe89917721e906152887bc040e..78e05573d81be4075663307250fe461a43be160d 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest_delegate.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest_delegate.h

@@ -38,9 +38,6 @@ class WebViewGuestDelegate {

// Called just after additional initialization is performed.

virtual void OnDidInitialize() = 0;

- // Called immediately after the guest WebContents has been destroyed.

- virtual void OnGuestDestroyed() = 0;

// Shows the context menu for the guest.

// |items| acts as a filter. This restricts the current context's default

// menu items to contain only the items from |items|.