extensions/browser/guest_view/web_view/web_view_guest.h - Issue 1181263007: WebView context menu cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 1181263007: WebView context menu cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments by lazyboy@. Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index e75b2c174cac10686b580fb193c077370e453809..26adb0a14f19e173e3faf7f2cf296091b04b57a1 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -58,10 +58,6 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,

std::string* partition_name,

bool* in_memory);

- // Returns guest_view::kInstanceIDNone if |contents| does not correspond to a

- // WebViewGuest.

- static int GetViewInstanceId(content::WebContents* contents);

static const char Type[];

// Returns the stored rules registry ID of the given webview. Will generate