base/process/process_metrics.h - Issue 1181263005: Make task manager memory data more efficient and meaningful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_metrics.h

Issue 1181263005: Make task manager memory data more efficient and meaningful. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust high threshold so it works with Dr Memory. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/process_metrics.h

diff --git a/base/process/process_metrics.h b/base/process/process_metrics.h

index 5916b94148cb2e6e9a6782096bcca49fd7b8f41a..8b4ec86693ac9aaceae50b1ce77d8549eaf32565 100644

--- a/base/process/process_metrics.h

+++ b/base/process/process_metrics.h

@@ -140,7 +140,8 @@ class BASE_EXPORT ProcessMetrics {

// memory usage as per definition of CommittedBytes.

void GetCommittedKBytes(CommittedKBytes* usage) const;

// Fills a WorkingSetKBytes containing resident private and shared memory

- // usage in bytes, as per definition of WorkingSetBytes.

+ // usage in bytes, as per definition of WorkingSetBytes. Note that this

+ // function is somewhat expensive on Windows (a few ms per process).

bool GetWorkingSetKBytes(WorkingSetKBytes* ws_usage) const;

#if defined(OS_MACOSX)

« no previous file with comments | « no previous file | base/process/process_metrics_win.cc » ('j') | no next file with comments »