Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5090)

Unified Diff: chrome/browser/task_manager/task_manager.h

Issue 1181263005: Make task manager memory data more efficient and meaningful. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reduced PdhGetFormattedCounterArray calls and now presubmit clean Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager.h
diff --git a/chrome/browser/task_manager/task_manager.h b/chrome/browser/task_manager/task_manager.h
index a9ff4f5eea50f521487afa1db4c238a74c69e28a..171905d56e09afc2a03fdb09fef4e06906d0cd3d 100644
--- a/chrome/browser/task_manager/task_manager.h
+++ b/chrome/browser/task_manager/task_manager.h
@@ -25,6 +25,7 @@ class TaskManagerModel;
class TaskManagerModelGpuDataManagerObserver;
namespace base {
+class PrivateWorkingSetSnapshot;
class ProcessMetrics;
}
@@ -284,6 +285,10 @@ class TaskManagerModel : public base::RefCountedThreadSafe<TaskManagerModel> {
// Updates the values for all rows.
void Refresh();
+ // Do a bulk repopulation of the physical_memory dataon platforms where that
+ // is faster.
+ void RefreshPhysicalMemoryFromWorkingSetSnapshot();
+
void NotifyVideoMemoryUsageStats(
const content::GPUVideoMemoryUsageStats& video_memory_usage_stats);
@@ -529,6 +534,10 @@ class TaskManagerModel : public base::RefCountedThreadSafe<TaskManagerModel> {
std::vector<base::Closure> on_data_ready_callbacks_;
+#if defined(OS_WIN)
+ scoped_ptr<base::PrivateWorkingSetSnapshot> working_set_snapshot_;
+#endif
+
// All per-Resource values are stored here.
mutable PerResourceCache per_resource_cache_;

Powered by Google App Engine
This is Rietveld 408576698