Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(42)

Issue 1181253006: Add test for style responsive animation behaviour (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add test for style responsive animation behaviour This adds a test helper for checking that animations correctly update themselves in response to style changes. This is intended to aid testing the InvalidatableStyleInterpolation refactor. BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197419

Patch Set 1 #

Total comments: 8

Patch Set 2 : Remove debugging change #

Patch Set 3 : Review changes #

Patch Set 4 : Remove setInlineStyle #

Patch Set 5 : Renamed transition to stateTransition to avoid confusion with CSS Transitions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -0 lines) Patch
A LayoutTests/animations/responsive/left-responsive.html View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/animations/responsive/resources/responsive-test.js View 1 2 3 4 1 chunk +191 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2015-06-18 06:00:03 UTC) #2
shans
https://codereview.chromium.org/1181253006/diff/1/LayoutTests/animations/responsive/resources/responsive-test.js File LayoutTests/animations/responsive/resources/responsive-test.js (right): https://codereview.chromium.org/1181253006/diff/1/LayoutTests/animations/responsive/resources/responsive-test.js#newcode53 LayoutTests/animations/responsive/resources/responsive-test.js:53: } for (var j = i + 1; ...
4 years, 10 months ago (2015-06-18 06:26:02 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1181253006/diff/1/LayoutTests/animations/responsive/resources/responsive-test.js File LayoutTests/animations/responsive/resources/responsive-test.js (right): https://codereview.chromium.org/1181253006/diff/1/LayoutTests/animations/responsive/resources/responsive-test.js#newcode53 LayoutTests/animations/responsive/resources/responsive-test.js:53: } On 2015/06/18 at 06:26:02, shans wrote: > for ...
4 years, 10 months ago (2015-06-18 07:11:33 UTC) #4
alancutter (OOO until 2018)
Removed setInlineStyle, PTAL.
4 years, 10 months ago (2015-06-18 23:49:26 UTC) #5
shans
lgtm
4 years, 10 months ago (2015-06-18 23:53:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181253006/80001
4 years, 10 months ago (2015-06-18 23:58:28 UTC) #9
darktears
I'm currently out of the office in vacations until Monday 6th of July. I will ...
4 years, 10 months ago (2015-06-18 23:58:38 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 02:09:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197419

Powered by Google App Engine
This is Rietveld 408576698