Issue 118123006: Better error reporting when passing a non-UTF8 file as script:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118123006: Better error reporting when passing a non-UTF8 file as script: (Closed)

Created:
6 years, 11 months ago by srdjan

Modified:
6 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Better error reporting when passing a non-UTF8 file as script: ./xcodebuild/DebugIA32/dart xcodebuild/DebugIA32/dart Before: Dart_NewStringFromUTF8 expects argument 'str' to be valid UTF-8. Now: ./xcodebuild/DebugIA32/dart is not a valid UTF-8 script R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31426

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/bin/dartutils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/bin/gen_snapshot.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

6 years, 11 months ago (2014-01-02 19:14:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31426 (presubmit successful).

Expand Messages | Collapse Messages