Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: net/disk_cache/backend_unittest.cc

Issue 118123004: Disk cache: Clarify API contract and delete spurious delay. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/disk_cache/disk_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_unittest.cc
diff --git a/net/disk_cache/backend_unittest.cc b/net/disk_cache/backend_unittest.cc
index 68da572debb3697dda9f301952106f4617175671..f4bc0c769e6a3a841b35f4d4ba4c04043f7c5ce7 100644
--- a/net/disk_cache/backend_unittest.cc
+++ b/net/disk_cache/backend_unittest.cc
@@ -1604,7 +1604,6 @@ void DiskCacheBackendTest::BackendDoomBetween() {
AddDelay();
Time middle_end = Time::Now();
- AddDelay();
gavinp 2014/03/21 11:20:39 This delay is not spurious; for caches that use co
rvargas (doing something else) 2014/03/21 18:14:41 Could you expand on that? The test as it is _with
ASSERT_EQ(net::OK, CreateEntry("fourth", &entry));
entry->Close();
@@ -3230,7 +3229,8 @@ TEST_F(DiskCacheBackendTest, SimpleDoomRecent) {
BackendDoomRecent();
}
-TEST_F(DiskCacheBackendTest, SimpleDoomBetween) {
+// crbug.com/330926
+TEST_F(DiskCacheBackendTest, DISABLED_SimpleDoomBetween) {
SetSimpleCacheMode();
BackendDoomBetween();
}
« no previous file with comments | « no previous file | net/disk_cache/disk_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698