Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 1181213007: DevTools: introduce CSS.setStyleText, we'll migrate setPropertyText to it later. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: introduce CSS.setStyleText, we'll migrate setPropertyText to it later. BUG=501311 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197474

Patch Set 1 #

Total comments: 8

Patch Set 2 : review comments addressed #

Total comments: 3

Patch Set 3 : for landing #

Patch Set 4 : rebaselined #

Patch Set 5 : win bot fix #

Patch Set 6 : win fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+777 lines, -148 lines) Patch
M LayoutTests/http/tests/inspector-protocol/css-protocol-test.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/css-set-inline-style-text.html View 1 1 chunk +110 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/css-set-inline-style-text-expected.txt View 1 1 chunk +23 lines, -0 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html View 1 2 3 3 chunks +6 lines, -18 lines 0 comments Download
A LayoutTests/inspector-protocol/css/css-set-style-text.html View 1 1 chunk +109 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/css-set-style-text-expected.txt View 1 2 3 1 chunk +218 lines, -0 lines 0 comments Download
A + LayoutTests/inspector-protocol/css/resources/set-style-text.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 7 chunks +136 lines, -19 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 7 chunks +10 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 10 chunks +150 lines, -103 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
pfeldman
4 years, 10 months ago (2015-06-17 13:07:42 UTC) #2
lushnikov
https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-protocol/css/css-set-style-text.html File LayoutTests/inspector-protocol/css/css-set-style-text.html (right): https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-protocol/css/css-set-style-text.html#newcode55 LayoutTests/inspector-protocol/css/css-set-style-text.html:55: }, dumpAndNext(next)); let's rather use undoAndNext. This way all ...
4 years, 10 months ago (2015-06-17 13:55:11 UTC) #3
lushnikov
https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-protocol/css/css-set-style-text.html File LayoutTests/inspector-protocol/css/css-set-style-text.html (right): https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-protocol/css/css-set-style-text.html#newcode83 LayoutTests/inspector-protocol/css/css-set-style-text.html:83: } let add also: 1. editing of inline style ...
4 years, 10 months ago (2015-06-17 13:58:04 UTC) #4
pfeldman
https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/InspectorCSSAgent.cpp#newcode299 Source/core/inspector/InspectorCSSAgent.cpp:299: SetRuleSelectorOrMediaAction(Type type, InspectorStyleSheet* styleSheet, const SourceRange& range, const String& ...
4 years, 10 months ago (2015-06-18 13:01:55 UTC) #5
lushnikov
lgtm https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html File LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html (right): https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html#newcode9 LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html:9: function sendCommand(command, properties, callback) you can remove this ...
4 years, 10 months ago (2015-06-18 13:34:49 UTC) #6
pfeldman
https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html File LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html (right): https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html#newcode9 LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html:9: function sendCommand(command, properties, callback) On 2015/06/18 13:34:49, lushnikov wrote: ...
4 years, 10 months ago (2015-06-18 16:38:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181213007/40001
4 years, 10 months ago (2015-06-19 06:20:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181213007/60001
4 years, 10 months ago (2015-06-19 06:25:00 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/48654)
4 years, 10 months ago (2015-06-19 06:43:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181213007/80001
4 years, 10 months ago (2015-06-19 10:50:27 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/48687)
4 years, 10 months ago (2015-06-19 11:12:18 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181213007/100001
4 years, 10 months ago (2015-06-19 12:55:45 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 14:44:22 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197474

Powered by Google App Engine
This is Rietveld 408576698