DevTools: introduce CSS.setStyleText, we'll migrate setPropertyText to it later.

DevTools: introduce CSS.setStyleText, we'll migrate setPropertyText to it later.

BUG=501311
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197474

[pfeldman, 2015-06-17 13:07:41]

pfeldman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2015-06-17 13:55:11]

https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-proto...
File LayoutTests/inspector-protocol/css/css-set-style-text.html (right):

https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-proto...
LayoutTests/inspector-protocol/css/css-set-style-text.html:55: },
dumpAndNext(next));
let's rather use undoAndNext. This way all tests from testSuite will be
independent
from each other.

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorCSSAgent.cpp:299:
SetRuleSelectorOrMediaAction(Type type, InspectorStyleSheet* styleSheet, const
SourceRange& range, const String& text)
SetModelTextAction?

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorCSSAgent.cpp:1002: InspectorStyleSheet*
inspectorStyleSheet = assertInspectorStyleSheetForId(errorString, styleSheetId);
you want inspectorStyleSheetBase here

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorStyleSheet.h (right):

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorStyleSheet.h:179:
RefPtrWillBeRawPtr<CSSStyleRule>  setStyleText(const SourceRange&, const String&
text, SourceRange* newRange, String* oldSelector, ExceptionState&);
this needs to be in InspectorStyleSheetBase

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorStyleSheet.h:214: bool findRuleByBodyRange(const
SourceRange&, CSSRule**, CSSRuleSourceData**);
ditto

[lushnikov, 2015-06-17 13:58:04]

https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-proto...
File LayoutTests/inspector-protocol/css/css-set-style-text.html (right):

https://codereview.chromium.org/1181213007/diff/1/LayoutTests/inspector-proto...
LayoutTests/inspector-protocol/css/css-set-style-text.html:83: }
let add also:
1. editing of inline style
2. editing of inline style with trailing comment
3. editing of regular style with trailing comment
4. deleting text alltogether

[pfeldman, 2015-06-18 13:01:55]

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorCSSAgent.cpp:299:
SetRuleSelectorOrMediaAction(Type type, InspectorStyleSheet* styleSheet, const
SourceRange& range, const String& text)
On 2015/06/17 13:55:10, lushnikov wrote:
> SetModelTextAction?

Done.

https://codereview.chromium.org/1181213007/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorCSSAgent.cpp:1002: InspectorStyleSheet*
inspectorStyleSheet = assertInspectorStyleSheetForId(errorString, styleSheetId);
On 2015/06/17 13:55:10, lushnikov wrote:
> you want inspectorStyleSheetBase here

Not really, plugged in differently.

[lushnikov, 2015-06-18 13:34:49]

lgtm

https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-p...
File LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html
(right):

https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-p...
LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html:9:
function sendCommand(command, properties, callback)
you can remove this and use sendCommandOrDie

https://codereview.chromium.org/1181213007/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorStyleSheet.h (right):

https://codereview.chromium.org/1181213007/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.h:287: 
stray line

[pfeldman, 2015-06-18 16:38:55]

https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-p...
File LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html
(right):

https://codereview.chromium.org/1181213007/diff/20001/LayoutTests/inspector-p...
LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html:9:
function sendCommand(command, properties, callback)
On 2015/06/18 13:34:49, lushnikov wrote:
> you can remove this and use sendCommandOrDie

Done.

[pfeldman, 2015-06-19 06:19:31]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-19 06:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1181213007/#ps40001
(title: "for landing")

[commit-bot: I haz the power, 2015-06-19 06:20:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181213007/40001

[pfeldman, 2015-06-19 06:21:38]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2015-06-19 06:24:31]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-19 06:24:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1181213007/#ps60001
(title: "rebaselined")

[commit-bot: I haz the power, 2015-06-19 06:25:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181213007/60001

[commit-bot: I haz the power, 2015-06-19 06:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 06:43:36]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[pfeldman, 2015-06-19 10:50:19]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-19 10:50:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1181213007/#ps80001
(title: "win bot fix")

[commit-bot: I haz the power, 2015-06-19 10:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181213007/80001

[commit-bot: I haz the power, 2015-06-19 11:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 11:12:18]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[pfeldman, 2015-06-19 12:55:33]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-19 12:55:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1181213007/#ps100001
(title: "win fixed")

[commit-bot: I haz the power, 2015-06-19 12:55:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181213007/100001

[commit-bot: I haz the power, 2015-06-19 14:44:22]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197474