Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/tracing/crash_service_uploader.h

Issue 1181213002: Slow Reports - Embed Metadata in Traces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tracing/crash_service_uploader.h
diff --git a/chrome/browser/tracing/crash_service_uploader.h b/chrome/browser/tracing/crash_service_uploader.h
index 5211f4303adc7e740f145dc13d499b1ec7999e0a..40592873120d494cc1ab36d177e2033baa46a8e0 100644
--- a/chrome/browser/tracing/crash_service_uploader.h
+++ b/chrome/browser/tracing/crash_service_uploader.h
@@ -39,6 +39,7 @@ class TraceCrashServiceUploader : public content::TraceUploader,
~TraceCrashServiceUploader() override;
void SetUploadURL(const std::string& url);
+ void SetMetadata(const std::map<std::string, std::string>& metadata);
// net::URLFetcherDelegate implementation.
void OnURLFetchComplete(const net::URLFetcher* source) override;
@@ -54,12 +55,12 @@ class TraceCrashServiceUploader : public content::TraceUploader,
private:
void DoUploadOnFileThread(const std::string& file_contents,
const std::string& upload_url,
+ const std::map<std::string, std::string>& metadata,
const UploadProgressCallback& progress_callback,
const UploadDoneCallback& done_callback);
// Sets up a multipart body to be uploaded. The body is produced according
// to RFC 2046.
- void SetupMultipart(const std::string& product,
- const std::string& version,
+ void SetupMultipart(const std::map<std::string, std::string> metadata,
oystein (OOO til 10th of July) 2015/06/12 18:14:16 &?
shatch 2015/06/12 19:05:54 Done.
const std::string& trace_filename,
const std::string& trace_contents,
std::string* post_data);
@@ -82,6 +83,7 @@ class TraceCrashServiceUploader : public content::TraceUploader,
net::URLRequestContextGetter* request_context_;
std::string upload_url_;
+ std::map<std::string, std::string> metadata_;
DISALLOW_COPY_AND_ASSIGN(TraceCrashServiceUploader);
};

Powered by Google App Engine
This is Rietveld 408576698