content/browser/tracing/background_tracing_manager_impl.h - Issue 1181213002: Slow Reports - Embed Metadata in Traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/background_tracing_manager_impl.h

Issue 1181213002: Slow Reports - Embed Metadata in Traces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/background_tracing_manager_impl.h

diff --git a/content/browser/tracing/background_tracing_manager_impl.h b/content/browser/tracing/background_tracing_manager_impl.h

index 9970e92b667d5442557effa9798ebf54b91f1581..7fce94a0b38febe885e192315b88bf2ed5b47930 100644

--- a/content/browser/tracing/background_tracing_manager_impl.h

+++ b/content/browser/tracing/background_tracing_manager_impl.h

@@ -45,6 +45,8 @@ class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {

void OnFinalizeComplete();

void BeginFinalizing(StartedFinalizingCallback);

+ scoped_ptr<base::DictionaryValue> GenerateMetadataDict() const;

std::string GetTriggerNameFromHandle(TriggerHandle handle) const;

bool IsTriggerHandleValid(TriggerHandle handle) const;