Source/core/dom/Element.cpp - Issue 1181183004: Recalc list items for <select> before updating style for the select.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 1181183004: Recalc list items for <select> before updating style for the select. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Call recalcListItems directly. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 4d361113e4fa9b9249b67d87c85b5c6477805ac0..bf897807466ee2d64ced0e9b67cd9a18595b45fe 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -1754,8 +1754,10 @@ ElementShadow& Element::ensureShadow()

void Element::pseudoStateChanged(CSSSelector::PseudoType pseudo)

{

- StyleResolver* styleResolver = document().styleResolver();

+ if (document().inStyleRecalc())

ojan 2015/06/19 01:05:02 Add a comment explaining why we do this?

+ return;

+ StyleResolver* styleResolver = document().styleResolver();

if (inActiveDocument() && styleResolver && styleChangeType() < SubtreeStyleChange)

document().styleEngine().pseudoStateChangedForElement(pseudo, *this);

}