Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/html/HTMLSelectElement.h

Issue 1181183004: Recalc list items for <select> before updating style for the select. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 void handleMouseRelease(); 127 void handleMouseRelease();
128 128
129 int listIndexForOption(const HTMLOptionElement&); 129 int listIndexForOption(const HTMLOptionElement&);
130 130
131 DECLARE_VIRTUAL_TRACE(); 131 DECLARE_VIRTUAL_TRACE();
132 132
133 protected: 133 protected:
134 HTMLSelectElement(Document&, HTMLFormElement*); 134 HTMLSelectElement(Document&, HTMLFormElement*);
135 135
136 private: 136 private:
137 virtual void willRecalcStyle(StyleRecalcChange) override;
138
137 virtual const AtomicString& formControlType() const override; 139 virtual const AtomicString& formControlType() const override;
138 140
139 virtual bool shouldShowFocusRingOnMouseFocus() const override; 141 virtual bool shouldShowFocusRingOnMouseFocus() const override;
140 142
141 virtual void dispatchFocusEvent(Element* oldFocusedElement, WebFocusType) ov erride; 143 virtual void dispatchFocusEvent(Element* oldFocusedElement, WebFocusType) ov erride;
142 virtual void dispatchBlurEvent(Element* newFocusedElement, WebFocusType) ove rride; 144 virtual void dispatchBlurEvent(Element* newFocusedElement, WebFocusType) ove rride;
143 145
144 virtual bool canStartSelection() const override { return false; } 146 virtual bool canStartSelection() const override { return false; }
145 147
146 virtual bool isEnumeratable() const override { return true; } 148 virtual bool isEnumeratable() const override { return true; }
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 bool m_multiple; 231 bool m_multiple;
230 bool m_activeSelectionState; 232 bool m_activeSelectionState;
231 mutable bool m_shouldRecalcListItems; 233 mutable bool m_shouldRecalcListItems;
232 int m_suggestedIndex; 234 int m_suggestedIndex;
233 bool m_isAutofilledByPreview; 235 bool m_isAutofilledByPreview;
234 }; 236 };
235 237
236 } // namespace blink 238 } // namespace blink
237 239
238 #endif // HTMLSelectElement_h 240 #endif // HTMLSelectElement_h
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698