Recalc list items for <select> before updating style for the select.

Recalc list items for <select> before updating style for the select.

listItems() might get called inside recalcStyle for a <select> which can then
schedule style invalidation sets or leave dirty bits after style recalc.

Instead we should make sure to call recalcListItems() at the start of
recalcStyle for <select> (in willRecalcStyle) so that all selected
<option>'s are updated before we try to update their style.

We also add an early out in Element::pseudoStateChanged so that we don't
schedule any invalidation sets inside recalcStyle which is bad since we'd
never process them. A future patch will add an ASSERT in the style invalidation
system to make sure we never do that another way as well.

BUG=497953
R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197420

[esprehn, 2015-06-18 22:56:46]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-18 22:57:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181183004/1

[esprehn, 2015-06-19 00:48:37]

esprehn@chromium.org changed reviewers:
+ ojan@chromium.org, rune@opera.com, timloh@chromium.org

[ojan, 2015-06-19 01:05:02]

lgtm

https://codereview.chromium.org/1181183004/diff/40001/Source/core/dom/Element...
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/1181183004/diff/40001/Source/core/dom/Element...
Source/core/dom/Element.cpp:1757: if (document().inStyleRecalc())
Add a comment explaining why we do this?

https://codereview.chromium.org/1181183004/diff/40001/Source/core/html/HTMLSe...
File Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/1181183004/diff/40001/Source/core/html/HTMLSe...
Source/core/html/HTMLSelectElement.cpp:1757: // TODO(esprehn): recalcListItems
will update the selected states of list
It's not clear what the TODO here is.

[esprehn, 2015-06-19 01:11:49]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2015-06-19 01:11:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ojan@chromium.org
Link to the patchset: https://codereview.chromium.org/1181183004/#ps80001
(title: "comments.")

[commit-bot: I haz the power, 2015-06-19 01:12:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181183004/80001

[commit-bot: I haz the power, 2015-06-19 01:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 01:21:48]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[esprehn, 2015-06-19 02:17:07]

Committed patchset #5 (id:80001) manually as 197420 (presubmit successful).