Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1181163002: Map::TryUpdate() must be in sync with Map::Update(). (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Map::TryUpdate() must be in sync with Map::Update(). This CL fixes elements kind transitions handling in Map::TryUpdate(). BUG=v8:4173 LOG=Y Committed: https://crrev.com/4cc4bc591cc8ffe7d458f4e89e1fbe3944d44c9f Cr-Commit-Position: refs/heads/master@{#28999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -8 lines) Patch
M src/objects.cc View 2 chunks +10 lines, -1 line 0 comments Download
M test/cctest/test-migrations.cc View 9 chunks +16 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-4121.js View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-12 11:22:38 UTC) #2
Toon Verwaest
lgtm
5 years, 6 months ago (2015-06-12 12:32:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181163002/1
5 years, 6 months ago (2015-06-12 12:35:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 12:36:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4cc4bc591cc8ffe7d458f4e89e1fbe3944d44c9f Cr-Commit-Position: refs/heads/master@{#28999}
5 years, 6 months ago (2015-06-12 12:36:47 UTC) #7
Igor Sheludko
5 years, 6 months ago (2015-06-12 12:43:49 UTC) #8
Message was sent while issue was closed.
This CL actually belongs to issue v8:4173.

Powered by Google App Engine
This is Rietveld 408576698