Add `.type` to the transformed InstanceMirror.

Add `.type` to the transformed InstanceMirror.
Also add `.qualifiedName` to the transformed ClassMirror.

BUG=
R=eernst@google.com

Committed: https://github.com/dart-lang/reflectable/commit/2cbaea2584b2114b6c68f839102dc80bc9acd2f5

[sigurdm, 2015-06-12 10:52:03]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-06-12 10:52:38]

sigurdm@google.com changed reviewers:
+ eernst@google.com

[eernst, 2015-06-18 10:15:11]

lgtm

https://codereview.chromium.org/1181153003/diff/20001/reflectable/lib/src/tra...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1181153003/diff/20001/reflectable/lib/src/tra...
reflectable/lib/src/transformer_implementation.dart:769: // library-mirrors.
Doesn't the qualified name _always_ include the library name? However, it seems
to be a problem that libraries don't have global names: The URI is not good
because it contains lots of chars that are not appropriate in identifiers, there
is no guarantee that we have a 'library' directive in any given library, and
prefixes used as "the name of a library" may differ in different importing
libraries (and the qualified name seems to be a global concept, so giving the
qualified name as seen from one point of view only may surprise users).

Maybe this problem can simply be pushed along to the analyzer folks, because we
could use their `qualifiedName`, and then all the problems, if any, could be
handled at the same time?

[sigurdm, 2015-06-18 10:43:40]

https://codereview.chromium.org/1181153003/diff/20001/reflectable/lib/src/tra...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1181153003/diff/20001/reflectable/lib/src/tra...
reflectable/lib/src/transformer_implementation.dart:769: // library-mirrors.
On 2015/06/18 10:15:11, eernst wrote:
> Doesn't the qualified name _always_ include the library name? However, it
seems
> to be a problem that libraries don't have global names: The URI is not good
> because it contains lots of chars that are not appropriate in identifiers,
there
> is no guarantee that we have a 'library' directive in any given library, and
> prefixes used as "the name of a library" may differ in different importing
> libraries (and the qualified name seems to be a global concept, so giving the
> qualified name as seen from one point of view only may surprise users).
> 
> Maybe this problem can simply be pushed along to the analyzer folks, because
we
> could use their `qualifiedName`, and then all the problems, if any, could be
> handled at the same time?

What I meant was, that an alternative implementation would say:
owner.qualifiedName + "." + simpleName and save space. Tried to clarify.

[sigurdm, 2015-06-18 10:44:36]

Committed patchset #2 (id:40001) manually as
2cbaea2584b2114b6c68f839102dc80bc9acd2f5 (presubmit successful).

[eernst, 2015-06-18 12:07:22]

lgtm

https://codereview.chromium.org/1181153003/diff/20001/reflectable/lib/src/tra...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1181153003/diff/20001/reflectable/lib/src/tra...
reflectable/lib/src/transformer_implementation.dart:769: // library-mirrors.
On 2015/06/18 10:43:40, sigurdm wrote:
> On 2015/06/18 10:15:11, eernst wrote:
> > Doesn't the qualified name _always_ include the library name? However, it
> seems
> > to be a problem that libraries don't have global names: The URI is not good
> > because it contains lots of chars that are not appropriate in identifiers,
> there
> > is no guarantee that we have a 'library' directive in any given library, and
> > prefixes used as "the name of a library" may differ in different importing
> > libraries (and the qualified name seems to be a global concept, so giving
the
> > qualified name as seen from one point of view only may surprise users).
> > 
> > Maybe this problem can simply be pushed along to the analyzer folks, because
> we
> > could use their `qualifiedName`, and then all the problems, if any, could be
> > handled at the same time?
> 
> What I meant was, that an alternative implementation would say:
> owner.qualifiedName + "." + simpleName and save space. Tried to clarify.

Acknowledged.