Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 6b71fdb51c8071f36a4ddc602336a223ce3c0ef3..5b1a9fde3edca9d0726e5ed8e36f9de5d6b679c4 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -805,13 +805,14 @@ void {{v8_class}}::installConditionallyEnabledProperties(v8::Local<v8::Object> i
{% for attribute in attributes if attribute.exposed_test %}
{% filter exposed(attribute.exposed_test) %}
- {% if attribute.is_expose_js_accessors %}
- static const V8DOMConfiguration::AccessorConfiguration accessorConfiguration = {{attribute_configuration(attribute)}};
- V8DOMConfiguration::installAccessor(isolate, prototypeObject, accessorConfiguration);
- {% else %}
- static const V8DOMConfiguration::AttributeConfiguration attributeConfiguration = {{attribute_configuration(attribute)}};
- V8DOMConfiguration::installAttribute(isolate, instanceObject, prototypeObject, attributeConfiguration);
- {% endif %}
+#error No one is actually using per-member [Exposed] extended attribute. Not supported. Contact to blink-reviews-bindings@ if you need.
+// TODO(yukishiino): Implement the feature again if there is a client.
+ {% endfilter %}
+ {% endfor %}
+ {% for method in methods if method.exposed_test %}
+ {% filter exposed(method.exposed_test) %}
+#error No one is actually using per-member [Exposed] extended attribute. Not supported. Contact to blink-reviews-bindings@ if you need.
+// TODO(yukishiino): Implement the feature again if there is a client.
{% endfilter %}
{% endfor %}
}
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698