Source/bindings/templates/interface_base.cpp - Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/templates/interface.cpp ('k') | Source/bindings/tests/results/core/V8SVGTestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/interface_base.cpp

diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp

index 1d817dd1f9eff827971e41c2c8afd5c37141524a..8190d34379914bbd4a3a89e43f4194db337fbbe4 100644

--- a/Source/bindings/templates/interface_base.cpp

+++ b/Source/bindings/templates/interface_base.cpp

@@ -338,7 +338,7 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function

{% if attribute.is_expose_js_accessors %}

static const V8DOMConfiguration::AccessorConfiguration accessorConfiguration =\

{{attribute_configuration(attribute)}};

- V8DOMConfiguration::installAccessor(isolate, prototypeTemplate, defaultSignature, accessorConfiguration);

+ V8DOMConfiguration::installAccessor(isolate, instanceTemplate, prototypeTemplate, functionTemplate, defaultSignature, accessorConfiguration);

{% else %}

static const V8DOMConfiguration::AttributeConfiguration attributeConfiguration =\

{{attribute_configuration(attribute)}};