Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index c736a026d980b26815bb35978f8932c83643e13c..f2ec7be7000faa737333944420c65969f90f179f 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -809,13 +809,14 @@ void {{v8_class}}::installConditionallyEnabledProperties(v8::Local<v8::Object> i
{% for attribute in attributes if attribute.exposed_test %}
{% filter exposed(attribute.exposed_test) %}
- {% if attribute.is_expose_js_accessors %}
- static const V8DOMConfiguration::AccessorConfiguration accessorConfiguration = {{attribute_configuration(attribute)}};
- V8DOMConfiguration::installAccessor(isolate, prototypeObject, accessorConfiguration);
- {% else %}
- static const V8DOMConfiguration::AttributeConfiguration attributeConfiguration = {{attribute_configuration(attribute)}};
- V8DOMConfiguration::installAttribute(isolate, instanceObject, prototypeObject, attributeConfiguration);
- {% endif %}
+#error No one is actually using per-member [Exposed] extended attribute. Removed the implementation.
haraken 2015/06/17 16:31:21 Removed => Remove
bashi 2015/06/18 02:16:27 Maybe this error says that the implementation has
Yuki 2015/06/18 07:44:41 Yes, I meant so. I updated the error message so i
+// TODO(yukishiino): Implement the feature again if there is a client.
+ {% endfilter %}
+ {% endfor %}
+ {% for method in methods if method.exposed_test %}
+ {% filter exposed(method.exposed_test) %}
+#error No one is actually using per-member [Exposed] extended attribute. Removed the implementation.
haraken 2015/06/17 16:31:21 Ditto.
+// TODO(yukishiino): Implement the feature again if there is a client.
{% endfilter %}
{% endfor %}
}

Powered by Google App Engine
This is Rietveld 408576698