bindings: Introduces on_{instance,prototype,interface} in the code generator.

Source/bindings/templates/attributes.cpp

 {% from 'conversions.cpp' import declare_enum_validation_variable, v8_value_to_local_cpp_value %}
 
 
 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
 {%- if attribute.is_expose_js_accessors %}
 const v8::FunctionCallbackInfo<v8::Value>& info
 {%- else %}
@@ skipping 510 matching lines @@
            attribute.constructor_type
        if attribute.constructor_type else '0' %}
 {% set access_control = 'static_cast<v8::AccessControl>(%s)' %
                         ' | '.join(attribute.access_control_list) %}
 {% set property_attribute = 'static_cast<v8::PropertyAttribute>(%s)' %
                             ' | '.join(attribute.property_attributes) %}
 {% set only_exposed_to_private_script =
        'V8DOMConfiguration::OnlyExposedToPrivateScript'
        if attribute.only_exposed_to_private_script else
        'V8DOMConfiguration::ExposedToAllScripts' %}
-{% set on_prototype = 'V8DOMConfiguration::OnPrototype'
-       if interface_name == 'Window' and attribute.idl_type == 'EventHandler'
-       else 'V8DOMConfiguration::OnInstance' %}
+{% set property_location_list = [] %}
+{% if attribute.on_instance %}
+{% set property_location_list = property_location_list + ['V8DOMConfiguration::OnInstance'] %}
+{% endif %}
+{% if attribute.on_prototype %}

[haraken, 2015/06/17 16:31:21]

if => elif ?

+{% set property_location_list = property_location_list + ['V8DOMConfiguration::OnPrototype'] %}
+{% endif %}
+{% if attribute.on_interface %}

[haraken, 2015/06/17 16:31:21]

if => elif ?

Maybe it would be better to use attribute.property_location, which takes either
of "instance", "prototype" or "interface", instead of introducing
attribute.on_instance, attribute.on_prototype and attribute.on_interface.

[Yuki, 2015/06/18 07:44:41]

I intend to make property_location bitflags.  One member can be placed at many
places.

+{% set property_location_list = property_location_list + ['V8DOMConfiguration::OnInterface'] %}
+{% endif %}
+{% set property_location = property_location_list | join(' | ') %}
 {% set holder_check = 'V8DOMConfiguration::DoNotCheckHolder'
        if attribute.is_lenient_this else 'V8DOMConfiguration::CheckHolder' %}
 {% set attribute_configuration_list = [
        '"%s"' % attribute.name,
        getter_callback,
        setter_callback,
        getter_callback_for_main_world,
        setter_callback_for_main_world,
        wrapper_type_info,
        access_control,
        property_attribute,
        only_exposed_to_private_script,
+       property_location,
+       holder_check,

[haraken, 2015/06/17 16:31:21]

alphabetical order

[bashi, 2015/06/18 02:16:27]

These are for AttributeConfiguration struct so we can't make them alphabetical
order.

    ] %}
-{% if attribute.is_expose_js_accessors %}
-{% set attribute_configuration_list = attribute_configuration_list
-                                    + [holder_check] %}
-{% else %}
-{% set attribute_configuration_list = attribute_configuration_list
-                                    + [on_prototype] %}
-{% endif %}
 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
 {%- endmacro %}