[microdump] Trim newline characters from input lines.

[microdump] Trim newline characters from input lines.

Removes the need to filter logcat files with "tr -d '\r'", allowing
microdump to act directly on files captured by 'adb logcat'.

BUG=chromium:410294

[simonb (inactive), 2015-06-16 11:05:18]

simonb@chromium.org changed reviewers:
+ primiano@chromium.org, thestig@chromium.org

[Primiano Tucci (use gerrit), 2015-06-16 11:16:03]

Thanks for fixing this.
LGTM but I think this is targeting the wrong repo.
I think you created this CL in the /breakpad/src of a chromium checkout.
What you really need to do to land this is pushing into the upstream SVN  repo,
you can't submit this here as external/google-breakpad is just a SVN->GIT mirror
of breakpad.

I wrote a doc to setup all the Git-SVN harness here: https://goo.gl/gs8w87
Can follow up offline on this bit.

https://codereview.chromium.org/1181113004/diff/1/processor/microdump.cc
File processor/microdump.cc (right):

https://codereview.chromium.org/1181113004/diff/1/processor/microdump.cc#newc...
processor/microdump.cc:81: if (str->size() > 0 && str->at(str->size() - 1) ==
'\r') {
femtonit, maybe !str->empty() %% *str.rbegin() == '\r' could be slightly more
legible.

[simonb (inactive), 2015-06-19 12:47:27]

Updates in patch set 2.  PTAL when convenient.  Thanks.

https://codereview.chromium.org/1181113004/diff/1/processor/microdump.cc
File processor/microdump.cc (right):

https://codereview.chromium.org/1181113004/diff/1/processor/microdump.cc#newc...
processor/microdump.cc:81: if (str->size() > 0 && str->at(str->size() - 1) ==
'\r') {
On 2015/06/16 11:16:03, Primiano Tucci wrote:
> femtonit, maybe !str->empty() %% *str.rbegin() == '\r' could be slightly more
> legible.

Half-done.  Also added copious commentary describing why this code is here.

[Primiano Tucci (use gerrit), 2015-06-19 12:57:22]

LGTM, plz make sure that "make check" is happy

[simonb (inactive), 2015-06-19 16:49:34]

On 2015/06/19 12:57:22, Primiano Tucci wrote:
> LGTM, plz make sure that "make check" is happy

make check" is ecstatic.

[Primiano Tucci (use gerrit), 2015-06-22 12:11:57]

On 2015/06/19 16:49:34, simonb wrote:
> On 2015/06/19 12:57:22, Primiano Tucci wrote:
> > LGTM, plz make sure that "make check" is happy
> 
> make check" is ecstatic.

Submitted (unfortunately with the wrong commit message) as r1461
https://code.google.com/p/google-breakpad/source/detail?r=1461