Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181113003: Implement V8Platform::CallDelayedOnForegroundThread. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement V8Platform::CallDelayedOnForegroundThread. The corresponding change on V8 side: https://codereview.chromium.org/1179153002 BUG=490559 Committed: https://crrev.com/06c3d1b9b782c2bdb3a4e121819351f95804cea5 Cr-Commit-Position: refs/heads/master@{#334592}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M gin/public/v8_platform.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gin/v8_platform.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
ulan
PTAL
5 years, 6 months ago (2015-06-16 08:33:48 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-16 08:43:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181113003/1
5 years, 6 months ago (2015-06-16 08:44:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/98610)
5 years, 6 months ago (2015-06-16 08:54:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181113003/20001
5 years, 6 months ago (2015-06-16 09:05:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/34232)
5 years, 6 months ago (2015-06-16 11:01:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181113003/20001
5 years, 6 months ago (2015-06-16 12:29:59 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 13:29:50 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/06c3d1b9b782c2bdb3a4e121819351f95804cea5 Cr-Commit-Position: refs/heads/master@{#334592}
5 years, 6 months ago (2015-06-16 13:30:52 UTC) #18
ulan
5 years, 6 months ago (2015-06-17 09:05:45 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1186173005/ by ulan@chromium.org.

The reason for reverting is: We need to first roll V8 with empty implementation
of the function and then use "override" here.

The trick with "virtual" does not work because chromium style checks for
"override"..

Powered by Google App Engine
This is Rietveld 408576698