Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 11811004: Revert 176986 - breaks tools/perf and tools/telemetry presubmit (Closed)

Created:
7 years, 11 months ago by nduca
Modified:
7 years, 11 months ago
Reviewers:
palmer
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 176986 - breaks tools/perf and tools/telemetry presubmit While I totally get this for production code, it doesn't apply to for example tools/perf, where we keep sitelists intentionally. Because this hooks into common checks, there's no clean way to disable it that I can see. > Warn when committing code with http:// URLs. > > We prefer HTTPS for everything, to the extent possible. > > NOTRY=true > BUG=156396 > > > Review URL: https://chromiumcodereview.appspot.com/11779037 TBR=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -77 lines) Patch
M PRESUBMIT.py View 8 chunks +28 lines, -77 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
nduca
7 years, 11 months ago (2013-01-16 03:55:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698