Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 1181093009: Changed cols and rows to unsigned long for HTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update LayoutTests to handle unsigned values Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTextAreaElement.h
diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h
index 9a88022a7c4804fe6f3a7dd324c0df5b2d110fe3..5cf050595d5bbca6ed56df23e3dabd6ffc1e433f 100644
--- a/Source/core/html/HTMLTextAreaElement.h
+++ b/Source/core/html/HTMLTextAreaElement.h
@@ -37,8 +37,8 @@ class CORE_EXPORT HTMLTextAreaElement final : public HTMLTextFormControlElement
public:
static PassRefPtrWillBeRawPtr<HTMLTextAreaElement> create(Document&, HTMLFormElement*);
- int cols() const { return m_cols; }
- int rows() const { return m_rows; }
+ unsigned cols() const { return m_cols; }
+ unsigned rows() const { return m_rows; }
bool shouldWrapText() const { return m_wrap != NoWrap; }
@@ -62,8 +62,8 @@ public:
virtual bool tooShort() const override;
bool isValidValue(const String&) const;
- void setCols(int);
- void setRows(int);
+ void setCols(unsigned);
+ void setRows(unsigned);
private:
HTMLTextAreaElement(Document&, HTMLFormElement*);
@@ -136,8 +136,8 @@ private:
bool tooLong(const String*, NeedsToCheckDirtyFlag) const;
bool tooShort(const String*, NeedsToCheckDirtyFlag) const;
- int m_rows;
- int m_cols;
+ unsigned m_rows;
+ unsigned m_cols;
WrapMethod m_wrap;
mutable String m_value;
mutable bool m_isDirty;
« no previous file with comments | « LayoutTests/fast/dom/HTMLTextAreaElement/rows-attribute-expected.txt ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698