Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181093009: Changed cols and rows to unsigned long for HTMLTextAreaElement (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
tkent, philipj_slow
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Changed cols and rows to unsigned long for HTMLTextAreaElement HTMLTextAreaElement should have rows and cols as unsigned long as per the specification. It has been updated to match this behavior. BUG=496400 R=philipj, rbyers Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197690

Patch Set 1 #

Patch Set 2 : Update LayoutTests to handle unsigned values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M LayoutTests/fast/dom/HTMLTextAreaElement/cols-attribute.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTextAreaElement/cols-attribute-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTextAreaElement/rows-attribute.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTextAreaElement/rows-attribute-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181093009/1
5 years, 6 months ago (2015-06-18 16:52:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59545)
5 years, 6 months ago (2015-06-18 18:14:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181093009/20001
5 years, 6 months ago (2015-06-19 09:20:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 10:40:01 UTC) #8
Habib Virji
Changes row and col to unsigned long to match the specification.
5 years, 6 months ago (2015-06-19 10:54:02 UTC) #9
Rick Byers
Replacing myself with tkent who is specifically interested in DOM API conformance.
5 years, 6 months ago (2015-06-23 21:12:18 UTC) #12
tkent
lgtm
5 years, 6 months ago (2015-06-23 23:34:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181093009/20001
5 years, 6 months ago (2015-06-23 23:34:48 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 00:52:50 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197690

Powered by Google App Engine
This is Rietveld 408576698