Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1181093008: Try again to rename one SkJpegUtility.h to remove ambiguity. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
msarett, scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Try again to rename one SkJpegUtility.h to remove ambiguity. This time rename the new codec one, which is not referenced externally. BUG=skia: Committed: https://skia.googlesource.com/skia/+/525e90ab92fed79ac11afbb6e13d56867157fa70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -148 lines) Patch
M gyp/codec.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkJpegCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkJpegDecoderMgr.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkJpegDecoderMgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/codec/SkJpegUtility.h View 1 chunk +0 lines, -50 lines 0 comments Download
D src/codec/SkJpegUtility.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
A + src/codec/SkJpegUtility_codec.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/codec/SkJpegUtility_codec.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
5 years, 6 months ago (2015-06-18 16:49:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181093008/1
5 years, 6 months ago (2015-06-18 16:50:05 UTC) #4
scroggo
Adding Matt, just in case, but lgtm
5 years, 6 months ago (2015-06-18 16:50:35 UTC) #6
msarett
lgtm
5 years, 6 months ago (2015-06-18 16:51:47 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-18 16:55:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181093008/1
5 years, 6 months ago (2015-06-18 16:58:14 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 16:59:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/525e90ab92fed79ac11afbb6e13d56867157fa70

Powered by Google App Engine
This is Rietveld 408576698