Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 1181083005: Use new Skia header file in test. (Closed)

Created:
5 years, 6 months ago by bungeman-chromium
Modified:
5 years, 6 months ago
Reviewers:
Mike West, pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new Skia header file in test. The content of the Skia header SkTypeface_android.h has moved into SkFontMgr_android.h since the old name was somewhat misleading, as it affected the font management, not the typefaces. The old header is now deprecated and will be removed soon, so move to the new one. Committed: https://crrev.com/cd4561dd87b6cd6a116d71356a2f5a6c7637105e Cr-Commit-Position: refs/heads/master@{#335037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/app/blink_test_platform_support_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
bungeman-chromium
5 years, 6 months ago (2015-06-17 22:11:35 UTC) #2
bungeman-chromium
5 years, 6 months ago (2015-06-17 22:12:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181083005/1
5 years, 6 months ago (2015-06-17 22:18:57 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 22:45:49 UTC) #8
Mike West
LGTM.
5 years, 6 months ago (2015-06-18 06:20:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181083005/1
5 years, 6 months ago (2015-06-18 14:24:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 14:37:41 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 14:38:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd4561dd87b6cd6a116d71356a2f5a6c7637105e
Cr-Commit-Position: refs/heads/master@{#335037}

Powered by Google App Engine
This is Rietveld 408576698