Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1181043002: Roll DEPS for mini_chromium for updates to base/posix/safe_strerror (Closed)

Created:
5 years, 6 months ago by Jackie Quinn
Modified:
5 years, 6 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Roll DEPS for mini_chromium for updates to base/posix/safe_strerror Also updates includes and usage of safe_strerror. BUG=499322 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/797adb320680a4a8ad39428075cca287e04b111f

Patch Set 1 #

Patch Set 2 : Remove include from mach_errors, as it doesn't use safe_strerror #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M test/errors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mac/mach_errors.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jackie Quinn
5 years, 6 months ago (2015-06-12 00:23:23 UTC) #2
Robert Sesek
LGTM
5 years, 6 months ago (2015-06-12 00:24:34 UTC) #3
Robert Sesek
5 years, 6 months ago (2015-06-12 00:25:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
797adb320680a4a8ad39428075cca287e04b111f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698