Source/core/css/parser/CSSParserValuesTest.cpp - Issue 1181023004: Move rem handling out of CSSParserValues.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserValuesTest.cpp

Issue 1181023004: Move rem handling out of CSSParserValues.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Another attempt Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSParserValuesTest.cpp

diff --git a/Source/core/css/parser/CSSParserValuesTest.cpp b/Source/core/css/parser/CSSParserValuesTest.cpp

index 87b431e703aa1c1390eb599e5ad319485cce9827..546ce851d92d8a3b1fc3e8aa739d1a249044be6d 100644

--- a/Source/core/css/parser/CSSParserValuesTest.cpp

+++ b/Source/core/css/parser/CSSParserValuesTest.cpp

@@ -104,8 +104,7 @@ TEST(CSSParserValuesTest, CSSParserValuelistClear)

TEST(CSSParserValuesTest, CSSParserTokenUrlConversion)

{

CSSTokenizer::Scope scope("url(some) uRL('test') UrL( \"words\" /**/ ) URl( /**/hi/**/ )");

- bool usesRemUnits;

- CSSParserValueList valueList(scope.tokenRange(), usesRemUnits);

+ CSSParserValueList valueList(scope.tokenRange());

ASSERT_EQ(valueList.size(), 4u);

ASSERT_EQ(valueList.valueAt(0)->unit(), CSSPrimitiveValue::UnitType::URI);

EXPECT_EQ(String(valueList.valueAt(0)->string), "some");