Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceInstARM32.h

Issue 1181013016: Subzero. Fixes memory leaks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: clang-format: for f in $(git diff --name-only HEAD~7); do if [[ ${f} == *h || ${f} == *cpp ]]; then… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceGlobalInits.h ('K') | « src/IceInst.h ('k') | src/IceInstX8632.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.h
diff --git a/src/IceInstARM32.h b/src/IceInstARM32.h
index 1ba5d4e9efd5a5a14adb96a811026193ffed8aba..208f89b11823615d4baf9bfa7403f22aea84a858 100644
--- a/src/IceInstARM32.h
+++ b/src/IceInstARM32.h
@@ -59,7 +59,6 @@ public:
protected:
OperandARM32(OperandKindARM32 Kind, Type Ty)
: Operand(static_cast<OperandKind>(Kind), Ty) {}
- ~OperandARM32() override {}
};
// OperandARM32Mem represents a memory operand in any of the various ARM32
@@ -141,7 +140,7 @@ private:
ConstantInteger32 *ImmOffset, AddrMode Mode);
OperandARM32Mem(Cfg *Func, Type Ty, Variable *Base, Variable *Index,
ShiftKind ShiftOp, uint16_t ShiftAmt, AddrMode Mode);
- ~OperandARM32Mem() override {}
+
Variable *Base;
ConstantInteger32 *ImmOffset;
Variable *Index;
@@ -167,7 +166,6 @@ public:
protected:
OperandARM32Flex(OperandKindARM32 Kind, Type Ty) : OperandARM32(Kind, Ty) {}
- ~OperandARM32Flex() override {}
};
// Rotated immediate variant.
@@ -202,7 +200,6 @@ public:
private:
OperandARM32FlexImm(Cfg *Func, Type Ty, uint32_t Imm, uint32_t RotateAmt);
- ~OperandARM32FlexImm() override {}
uint32_t Imm;
uint32_t RotateAmt;
@@ -238,7 +235,6 @@ public:
private:
OperandARM32FlexReg(Cfg *Func, Type Ty, Variable *Reg, ShiftKind ShiftOp,
Operand *ShiftAmt);
- ~OperandARM32FlexReg() override {}
Variable *Reg;
ShiftKind ShiftOp;
@@ -295,7 +291,7 @@ public:
protected:
InstARM32(Cfg *Func, InstKindARM32 Kind, SizeT Maxsrcs, Variable *Dest)
: InstTarget(Func, static_cast<InstKind>(Kind), Maxsrcs, Dest) {}
- ~InstARM32() override {}
+
static bool isClassof(const Inst *Inst, InstKindARM32 MyKind) {
return Inst->getKind() == static_cast<InstKind>(MyKind);
}
@@ -376,7 +372,7 @@ private:
: InstARM32Pred(Func, K, 1, Dest, Predicate) {
addSource(Src);
}
- ~InstARM32UnaryopGPR() override {}
+
static const char *Opcode;
};
@@ -422,7 +418,7 @@ private:
addSource(Dest);
addSource(Src);
}
- ~InstARM32TwoAddrGPR() override {}
+
static const char *Opcode;
};
@@ -464,7 +460,6 @@ private:
: InstARM32Pred(Func, K, 1, Dest, Predicate) {
addSource(Source);
}
- ~InstARM32Movlike() override {}
static const char *Opcode;
};
@@ -515,7 +510,7 @@ private:
addSource(Src1);
addSource(Src2);
}
- ~InstARM32ThreeAddrGPR() override {}
+
static const char *Opcode;
bool SetFlags;
};
@@ -601,7 +596,7 @@ public:
private:
InstARM32Br(Cfg *Func, const CfgNode *TargetTrue, const CfgNode *TargetFalse,
CondARM32::Cond Predicate);
- ~InstARM32Br() override {}
+
const CfgNode *TargetTrue;
const CfgNode *TargetFalse;
};
@@ -627,7 +622,6 @@ public:
private:
InstARM32Call(Cfg *Func, Variable *Dest, Operand *CallTarget);
- ~InstARM32Call() override {}
};
// Integer compare instruction.
@@ -650,7 +644,6 @@ public:
private:
InstARM32Cmp(Cfg *Func, Variable *Src1, Operand *Src2,
CondARM32::Cond Predicate);
- ~InstARM32Cmp() override {}
};
// Load instruction.
@@ -674,7 +667,6 @@ public:
private:
InstARM32Ldr(Cfg *Func, Variable *Dest, OperandARM32Mem *Mem,
CondARM32::Cond Predicate);
- ~InstARM32Ldr() override {}
};
// Multiply Accumulate: d := x * y + a
@@ -699,7 +691,6 @@ public:
private:
InstARM32Mla(Cfg *Func, Variable *Dest, Variable *Src0, Variable *Src1,
Variable *Acc, CondARM32::Cond Predicate);
- ~InstARM32Mla() override {}
};
// Pop into a list of GPRs. Technically this can be predicated, but we don't
@@ -720,7 +711,7 @@ public:
private:
InstARM32Pop(Cfg *Func, const VarList &Dests);
- ~InstARM32Pop() override {}
+
VarList Dests;
};
@@ -742,7 +733,6 @@ public:
private:
InstARM32Push(Cfg *Func, const VarList &Srcs);
- ~InstARM32Push() override {}
};
// Ret pseudo-instruction. This is actually a "bx" instruction with
@@ -771,7 +761,6 @@ public:
private:
InstARM32Ret(Cfg *Func, Variable *LR, Variable *Source);
- ~InstARM32Ret() override {}
};
// Store instruction. It's important for liveness that there is no Dest
@@ -796,7 +785,6 @@ public:
private:
InstARM32Str(Cfg *Func, Variable *Value, OperandARM32Mem *Mem,
CondARM32::Cond Predicate);
- ~InstARM32Str() override {}
};
// Unsigned Multiply Long: d.lo, d.hi := x * y
@@ -821,7 +809,7 @@ public:
private:
InstARM32Umull(Cfg *Func, Variable *DestLo, Variable *DestHi, Variable *Src0,
Variable *Src1, CondARM32::Cond Predicate);
- ~InstARM32Umull() override {}
+
Variable *DestHi;
};
« src/IceGlobalInits.h ('K') | « src/IceInst.h ('k') | src/IceInstX8632.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698