Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: src/IceGlobalInits.cpp

Issue 1181013016: Subzero. Fixes memory leaks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: clang-format: for f in $(git diff --name-only HEAD~7); do if [[ ${f} == *h || ${f} == *cpp ]]; then… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceGlobalInits.cpp
diff --git a/src/IceGlobalInits.cpp b/src/IceGlobalInits.cpp
index c9bdf9908191e578de7834eb4f62d58a8136d70e..2ee5e625aa8a77694d8d3a1b034950bd4edef423 100644
--- a/src/IceGlobalInits.cpp
+++ b/src/IceGlobalInits.cpp
@@ -60,12 +60,6 @@ void dumpCallingConv(Ice::Ostream &, llvm::CallingConv::ID CallingConv) {
namespace Ice {
-FunctionDeclaration *FunctionDeclaration::create(
- const FuncSigType &Signature, llvm::CallingConv::ID CallingConv,
- llvm::GlobalValue::LinkageTypes Linkage, bool IsProto) {
- return new FunctionDeclaration(Signature, CallingConv, Linkage, IsProto);
-}
-
void FunctionDeclaration::dumpType(Ostream &Stream) const {
if (!ALLOW_DUMP)
return;
@@ -92,23 +86,15 @@ void FunctionDeclaration::dump(GlobalContext *Ctx, Ostream &Stream) const {
Stream << ")";
}
-VariableDeclaration *VariableDeclaration::create() {
- return new VariableDeclaration();
-}
-
-VariableDeclaration::~VariableDeclaration() {
- llvm::DeleteContainerPointers(Initializers);
-}
-
void VariableDeclaration::dumpType(Ostream &Stream) const {
if (!ALLOW_DUMP)
return;
- if (Initializers.size() == 1) {
- Initializers.front()->dumpType(Stream);
+ if (Initializers->size() == 1) {
+ Initializers->front()->dumpType(Stream);
} else {
Stream << "<{ ";
bool IsFirst = true;
- for (Initializer *Init : Initializers) {
+ for (const std::unique_ptr<Initializer> &Init : *Initializers) {
if (IsFirst) {
IsFirst = false;
} else {
@@ -130,13 +116,13 @@ void VariableDeclaration::dump(GlobalContext *Ctx, Ostream &Stream) const {
Stream << " " << (IsConstant ? "constant" : "global") << " ";
// Add initializer.
- if (Initializers.size() == 1) {
- Initializers.front()->dump(Stream);
+ if (Initializers->size() == 1) {
+ Initializers->front()->dump(Stream);
} else {
dumpType(Stream);
Stream << " <{ ";
bool IsFirst = true;
- for (Initializer *Init : Initializers) {
+ for (const std::unique_ptr<Initializer> &Init : *Initializers) {
if (IsFirst) {
IsFirst = false;
} else {
« src/IceGlobalInits.h ('K') | « src/IceGlobalInits.h ('k') | src/IceInst.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698