Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: src/IceELFObjectWriter.cpp

Issue 1181013016: Subzero. Fixes memory leaks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: clang-format: for f in $(git diff --name-only HEAD~7); do if [[ ${f} == *h || ${f} == *cpp ]]; then… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceELFObjectWriter.cpp
diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp
index 44f4adb373c20238bc565d8e55251dae226cab1b..68daad045945e8cef74e5ad26f2138fbf83ae7b8 100644
--- a/src/IceELFObjectWriter.cpp
+++ b/src/IceELFObjectWriter.cpp
@@ -387,11 +387,12 @@ void ELFObjectWriter::writeDataOfType(SectionType ST,
Section->setSize(Section->getCurrentSize() + SymbolSize);
} else {
assert(ST != BSS);
- for (VariableDeclaration::Initializer *Init : Var->getInitializers()) {
+ for (const std::unique_ptr<VariableDeclaration::Initializer> &Init :
+ Var->getInitializers()) {
switch (Init->getKind()) {
case VariableDeclaration::Initializer::DataInitializerKind: {
const auto Data = llvm::cast<VariableDeclaration::DataInitializer>(
- Init)->getContents();
+ Init.get())->getContents();
Section->appendData(Str, llvm::StringRef(Data.data(), Data.size()));
break;
}
@@ -400,7 +401,7 @@ void ELFObjectWriter::writeDataOfType(SectionType ST,
break;
case VariableDeclaration::Initializer::RelocInitializerKind: {
const auto Reloc =
- llvm::cast<VariableDeclaration::RelocInitializer>(Init);
+ llvm::cast<VariableDeclaration::RelocInitializer>(Init.get());
AssemblerFixup NewFixup;
NewFixup.set_position(Section->getCurrentSize());
NewFixup.set_kind(RelocationKind);

Powered by Google App Engine
This is Rietveld 408576698