Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/IceCfg.cpp

Issue 1181013016: Subzero. Fixes memory leaks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: clang-format: for f in $(git diff --name-only HEAD~7); do if [[ ${f} == *h || ${f} == *cpp ]]; then… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceConverter.cpp » ('j') | src/IceDefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.cpp
diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp
index 2cbe571c815035b22cf054830a5c8617ed844f19..bf9e58e9175e7059cafb42f2eb31edaad2364c5e 100644
--- a/src/IceCfg.cpp
+++ b/src/IceCfg.cpp
@@ -80,11 +80,12 @@ namespace {
constexpr char BlockNameGlobalPrefix[] = ".L$profiler$block_name$";
constexpr char BlockStatsGlobalPrefix[] = ".L$profiler$block_info$";
-VariableDeclaration *nodeNameDeclaration(const IceString &NodeAsmName) {
- VariableDeclaration *Var = VariableDeclaration::create();
+VariableDeclaration *nodeNameDeclaration(GlobalContext *Ctx,
+ const IceString &NodeAsmName) {
+ VariableDeclaration *Var = VariableDeclaration::create(Ctx);
Var->setName(BlockNameGlobalPrefix + NodeAsmName);
Var->setIsConstant(true);
- Var->addInitializer(new VariableDeclaration::DataInitializer(
+ Var->addInitializer(VariableDeclaration::DataInitializer::create(
NodeAsmName.data(), NodeAsmName.size() + 1));
const SizeT Int64ByteSize = typeWidthInBytes(IceType_i64);
Var->setAlignment(Int64ByteSize); // Wasteful, 32-bit could use 4 bytes.
@@ -92,20 +93,20 @@ VariableDeclaration *nodeNameDeclaration(const IceString &NodeAsmName) {
}
VariableDeclaration *
-blockProfilingInfoDeclaration(const IceString &NodeAsmName,
+blockProfilingInfoDeclaration(GlobalContext *Ctx, const IceString &NodeAsmName,
VariableDeclaration *NodeNameDeclaration) {
- VariableDeclaration *Var = VariableDeclaration::create();
+ VariableDeclaration *Var = VariableDeclaration::create(Ctx);
Var->setName(BlockStatsGlobalPrefix + NodeAsmName);
const SizeT Int64ByteSize = typeWidthInBytes(IceType_i64);
- Var->addInitializer(new VariableDeclaration::ZeroInitializer(Int64ByteSize));
+ Var->addInitializer(
+ VariableDeclaration::ZeroInitializer::create(Int64ByteSize));
const RelocOffsetT NodeNameDeclarationOffset = 0;
- Var->addInitializer(new VariableDeclaration::RelocInitializer(
+ Var->addInitializer(VariableDeclaration::RelocInitializer::create(
NodeNameDeclaration, NodeNameDeclarationOffset));
Var->setAlignment(Int64ByteSize);
return Var;
}
-
} // end of anonymous namespace
void Cfg::profileBlocks() {
@@ -114,9 +115,9 @@ void Cfg::profileBlocks() {
for (CfgNode *Node : Nodes) {
IceString NodeAsmName = Node->getAsmName();
- GlobalInits->push_back(nodeNameDeclaration(NodeAsmName));
+ GlobalInits->push_back(nodeNameDeclaration(Ctx, NodeAsmName));
GlobalInits->push_back(
- blockProfilingInfoDeclaration(NodeAsmName, GlobalInits->back()));
+ blockProfilingInfoDeclaration(Ctx, NodeAsmName, GlobalInits->back()));
Node->profileExecutionCount(GlobalInits->back());
}
}
« no previous file with comments | « no previous file | src/IceConverter.cpp » ('j') | src/IceDefs.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698