Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181013011: Support CreateDataProperty on JSObject in the runtime (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support CreateDataProperty on JSObject in the runtime BUG=v8:4137 LOG=n Committed: https://crrev.com/bb23bccb8b1356e89d274db290cf9a08ef662238 Cr-Commit-Position: refs/heads/master@{#29080}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M src/api.cc View 2 chunks +14 lines, -64 lines 1 comment Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-12 16:34:15 UTC) #2
Jakob Kummerow
LGTM. https://codereview.chromium.org/1181013011/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1181013011/diff/1/src/api.cc#newcode3506 src/api.cc:3506: i::Handle<i::JSObject> self = Utils::OpenHandle(this); Yay! :-)
5 years, 6 months ago (2015-06-17 10:53:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181013011/1
5 years, 6 months ago (2015-06-17 10:57:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 11:25:28 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 11:25:47 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bb23bccb8b1356e89d274db290cf9a08ef662238
Cr-Commit-Position: refs/heads/master@{#29080}

Powered by Google App Engine
This is Rietveld 408576698