Support impl-side painting in Mandoline.

mojo/gles2/command_buffer_client_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/gles2/command_buffer_client_impl.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/process/process_handle.h"
 #include "components/view_manager/gles2/command_buffer_type_conversions.h"
 #include "components/view_manager/gles2/mojo_buffer_backing.h"
+#include "components/view_manager/gles2/mojo_gpu_memory_buffer.h"
+#include "gpu/command_buffer/service/image_factory.h"
+#include "mojo/platform_handle/platform_handle_functions.h"
 
 namespace gles2 {
 
 namespace {
 
 bool CreateMapAndDupSharedBuffer(size_t size,
                                  void** memory,
                                  mojo::ScopedSharedBufferHandle* handle,
                                  mojo::ScopedSharedBufferHandle* duped) {
   MojoResult result = mojo::CreateSharedBuffer(NULL, size, handle);
@@ skipping 215 matching lines @@
 }
 
 gpu::Capabilities CommandBufferClientImpl::GetCapabilities() {
   return capabilities_;
 }
 
 int32_t CommandBufferClientImpl::CreateImage(ClientBuffer buffer,
                                              size_t width,
                                              size_t height,
                                              unsigned internalformat) {
-  // TODO(piman)
-  NOTIMPLEMENTED();
-  return -1;
+  int32 new_id = next_image_id_.GetNext();
+
+  mojo::SizePtr size = mojo::Size::New();
+  size->width = width;

[yzshen1, 2015/06/15 20:04:42]

FYI, I tried to compile the patch on Windows and it complained about conversion:

==================
d:\src\cr6\src\mojo\gles2\command_buffer_client_impl.cc(254) : error C2220:
warning treated as error - no 'object' file generated
d:\src\cr6\src\mojo\gles2\command_buffer_client_impl.cc(254) : warning C4267:
'=' : conversion from 'size_t' to 'int32_t', possible loss of data
d:\src\cr6\src\mojo\gles2\command_buffer_client_impl.cc(255) : warning C4267:
'=' : conversion from 'size_t' to 'int32_t', possible loss of data
d:\src\cr6\src\mojo\gles2\command_buffer_client_impl.cc(310) : warning C4267:
'argument' : conversion from 'size_t' to 'int', possible loss of data

[jam, 2015/06/15 22:06:02]

that's strange, i'm compiling on Windows and I don't see that!
what are your build GN build args?

[yzshen1, 2015/06/16 16:34:25]

That is strange. I didn't explicitly set any gn args. When I ran 'gn args
out\Debug' it showed no args.

+  size->height = height;
+
+  MojoGpuMemoryBufferImpl* gpu_memory_buffer =
+      MojoGpuMemoryBufferImpl::FromClientBuffer(buffer);
+  gfx::GpuMemoryBufferHandle handle = gpu_memory_buffer->GetHandle();
+
+  bool requires_sync_point = false;
+  base::SharedMemoryHandle dupd_handle =
+      base::SharedMemory::DuplicateHandle(handle.handle);
+#if defined(OS_WIN)
+  HANDLE platform_handle = dupd_handle;
+#else
+  int platform_handle = dupd_handle.fd;
+#endif
+
+  if (handle.type != gfx::SHARED_MEMORY_BUFFER) {
+    requires_sync_point = true;
+    NOTIMPLEMENTED();
+    return -1;
+  }
+
+  MojoHandle mojo_handle = MOJO_HANDLE_INVALID;
+  MojoResult create_result = MojoCreatePlatformHandleWrapper(
+      platform_handle, &mojo_handle);
+  if (create_result != MOJO_RESULT_OK) {
+    NOTIMPLEMENTED();
+    return -1;
+  }
+  mojo::ScopedHandle scoped_handle;
+  scoped_handle.reset(mojo::Handle(mojo_handle));
+  command_buffer_->CreateImage(new_id,
+                               scoped_handle.Pass(),
+                               handle.type,
+                               size.Pass(),
+                               gpu_memory_buffer->GetFormat(),
+                               internalformat);
+  if (requires_sync_point) {
+    NOTIMPLEMENTED();
+    //gpu_memory_buffer_manager->SetDestructionSyncPoint(gpu_memory_buffer,

[danakj, 2015/06/15 18:20:36]

is a TODO needed?

[jam, 2015/06/15 22:06:01]

Done.

+    //                                                   InsertSyncPoint());

[piman, 2015/06/15 18:14:33]

nit: remove/add TODO?

[jam, 2015/06/15 22:06:01]

Done.

+  }
+
+  return new_id;
 }
 
 void CommandBufferClientImpl::DestroyImage(int32 id) {
-  // TODO(piman)
-  NOTIMPLEMENTED();
+  command_buffer_->DestroyImage(id);
 }
 
 int32_t CommandBufferClientImpl::CreateGpuMemoryBufferImage(
     size_t width,
     size_t height,
     unsigned internalformat,
     unsigned usage) {
-  // TODO(piman)
-  NOTIMPLEMENTED();
-  return -1;
+  scoped_ptr<gfx::GpuMemoryBuffer> buffer(MojoGpuMemoryBufferImpl::Create(
+      gfx::Size(width, height),
+      gpu::ImageFactory::ImageFormatToGpuMemoryBufferFormat(internalformat),
+      gpu::ImageFactory::ImageUsageToGpuMemoryBufferUsage(usage)));
+  if (!buffer)
+    return -1;
+
+  return CreateImage(buffer->AsClientBuffer(), width, height, internalformat);
 }
 
 uint32_t CommandBufferClientImpl::InsertSyncPoint() {
   command_buffer_->InsertSyncPoint(true);
   return sync_point_client_impl_->WaitForInsertSyncPoint();
 }
 
 uint32_t CommandBufferClientImpl::InsertFutureSyncPoint() {
   command_buffer_->InsertSyncPoint(false);
   return sync_point_client_impl_->WaitForInsertSyncPoint();
@@ skipping 58 matching lines @@
 
 void CommandBufferClientImpl::SetLock(base::Lock* lock) {
 }
 
 bool CommandBufferClientImpl::IsGpuChannelLost() {
   // This is only possible for out-of-process command buffers.
   return false;
 }
 
 }  // namespace gles2