Support impl-side painting in Mandoline.

gpu/command_buffer/build_gles2_cmd_buffer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """code generator for GLES2 command buffers."""
 
 import itertools
 import os
 import os.path
@@ skipping 2291 matching lines @@
   },
   'CreateImageCHROMIUM': {
     'type': 'Manual',
     'cmd_args':
         'ClientBuffer buffer, GLsizei width, GLsizei height, '
         'GLenum internalformat',
     'result': ['GLuint'],
     'client_test': False,
     'gen_cmd': False,
     'expectation': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",
     'chromium': True,
     'trace_level': 1,
   },
   'DestroyImageCHROMIUM': {
     'type': 'Manual',
     'client_test': False,
     'gen_cmd': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",
     'chromium': True,
     'trace_level': 1,
   },
   'CreateGpuMemoryBufferImageCHROMIUM': {
     'type': 'Manual',
     'cmd_args':
         'GLsizei width, GLsizei height, GLenum internalformat, GLenum usage',
     'result': ['GLuint'],
     'client_test': False,
     'gen_cmd': False,
     'expectation': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",
     'chromium': True,
     'trace_level': 1,
   },
   'CreateProgram': {
     'type': 'Create',
     'client_test': False,
   },
   'CreateShader': {
     'type': 'Create',
     'client_test': False,
@@ skipping 705 matching lines @@
     'expectation': False,
     'unsafe': True,
   },
   'LinkProgram': {
     'decoder_func': 'DoLinkProgram',
     'impl_func':  False,
     'trace_level': 1,
   },
   'MapBufferCHROMIUM': {
     'gen_cmd': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",

[piman, 2015/06/15 18:14:33]

nit: CHROMIUM_pixel_transfer_buffer_object
I realize this extension was not documented, but this is the extension name
that's associated with the functionality in the header.

[jam, 2015/06/15 22:06:01]

Done.

     'chromium': True,
     'client_test': False,
     'trace_level': 1,
   },
   'MapBufferSubDataCHROMIUM': {
     'gen_cmd': False,
     'extension': True,
     'chromium': True,
     'client_test': False,
     'pepper_interface': 'ChromiumMapSub',
@@ skipping 395 matching lines @@
     'count': 12,
     'unsafe': True,
   },
   'UniformBlockBinding': {
     'type': 'Custom',
     'impl_func': False,
     'unsafe': True,
   },
   'UnmapBufferCHROMIUM': {
     'gen_cmd': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",

[piman, 2015/06/15 18:14:33]

CHROMIUM_pixel_transfer_buffer_object

[jam, 2015/06/15 22:06:01]

Done.

     'chromium': True,
     'client_test': False,
     'trace_level': 1,
   },
   'UnmapBufferSubDataCHROMIUM': {
     'gen_cmd': False,
     'extension': True,
     'chromium': True,
     'client_test': False,
     'pepper_interface': 'ChromiumMapSub',
@@ skipping 132 matching lines @@
   'TexImageIOSurface2DCHROMIUM': {
     'decoder_func': 'DoTexImageIOSurface2DCHROMIUM',
     'unit_test': False,
     'extension': True,
     'chromium': True,
     'trace_level': 1,
   },
   'CopyTextureCHROMIUM': {
     'decoder_func': 'DoCopyTextureCHROMIUM',
     'unit_test': False,
-    'extension': True,
+    'extension': "CHROMIUM_copy_texture",
     'chromium': True,
     'trace_level': 2,
   },
   'CopySubTextureCHROMIUM': {
     'decoder_func': 'DoCopySubTextureCHROMIUM',
     'unit_test': False,
-    'extension': True,
+    'extension': "CHROMIUM_copy_texture",
     'chromium': True,
     'trace_level': 2,
   },
   'TexStorage2DEXT': {
     'unit_test': False,
     'extension': True,
     'decoder_func': 'DoTexStorage2DEXT',
     'trace_level': 2,
   },
   'DrawArraysInstancedANGLE': {
@@ skipping 156 matching lines @@
     'extension': True,
     'gl_test_func': 'glIsVertexArrayOES',
     'decoder_func': 'DoIsVertexArrayOES',
     'expectation': False,
     'unit_test': False,
     'pepper_interface': 'VertexArrayObject',
   },
   'BindTexImage2DCHROMIUM': {
     'decoder_func': 'DoBindTexImage2DCHROMIUM',
     'unit_test': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",
     'chromium': True,
   },
   'ReleaseTexImage2DCHROMIUM': {
     'decoder_func': 'DoReleaseTexImage2DCHROMIUM',
     'unit_test': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",
     'chromium': True,
   },
   'ShallowFinishCHROMIUM': {
     'impl_func': False,
     'gen_cmd': False,
     'extension': True,
     'chromium': True,
     'client_test': False,
   },
   'ShallowFlushCHROMIUM': {
@@ skipping 31 matching lines @@
     'data_transfer_methods': ['shm'],
     'client_test': False,
     'cmd_args': 'GLenumTextureTarget target, GLint level, '
         'GLintTextureInternalFormat internalformat, '
         'GLsizei width, GLsizei height, '
         'GLintTextureBorder border, '
         'GLenumTextureFormat format, GLenumPixelType type, '
         'const void* pixels, '
         'uint32_t async_upload_token, '
         'void* sync_data',
-    'extension': True,
+    'extension': "CHROMIUM_image",

[piman, 2015/06/15 18:14:33]

nit: CHROMIUM_async_pixel_transfers (same deal).

[danakj, 2015/06/15 18:20:35]

And, FWIW if you use_one_copy = true, you probably don't need to add these async
things to the mojo autogens

[jam, 2015/06/15 22:06:01]

set use_one_copy=true, and removed all changes that piman commented to use
CHROMIUM_async_pixel_transfers for

     'chromium': True,
     'trace_level': 2,
   },
   'AsyncTexSubImage2DCHROMIUM': {
     'type': 'Manual',
     'data_transfer_methods': ['shm'],
     'client_test': False,
     'cmd_args': 'GLenumTextureTarget target, GLint level, '
         'GLint xoffset, GLint yoffset, '
         'GLsizei width, GLsizei height, '
         'GLenumTextureFormat format, GLenumPixelType type, '
         'const void* data, '
         'uint32_t async_upload_token, '
         'void* sync_data',
-    'extension': True,
+    'extension': "CHROMIUM_image",

[piman, 2015/06/15 18:14:33]

nit: CHROMIUM_async_pixel_transfers

     'chromium': True,
     'trace_level': 2,
   },
   'WaitAsyncTexImage2DCHROMIUM': {
     'type': 'Manual',
     'client_test': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",

[piman, 2015/06/15 18:14:33]

nit: CHROMIUM_async_pixel_transfers

     'chromium': True,
     'trace_level': 1,
   },
   'WaitAllAsyncTexImage2DCHROMIUM': {
     'type': 'Manual',
     'client_test': False,
-    'extension': True,
+    'extension': "CHROMIUM_image",

[piman, 2015/06/15 18:14:33]

nit: CHROMIUM_async_pixel_transfers

     'chromium': True,
     'trace_level': 1,
   },
   'DiscardFramebufferEXT': {
     'type': 'PUTn',
     'count': 1,
     'decoder_func': 'DoDiscardFramebufferEXT',
     'unit_test': False,
     'client_test': False,
     'extension_flag': 'ext_discard_framebuffer',
@@ skipping 718 matching lines @@
                (func.return_type, func.original_name,
                 func.MakeTypedOriginalArgString("")))
 
   def WriteMojoGLES2Impl(self, func, file):
     """Writes the Mojo GLES2 implementation."""
     file.Write("%s MojoGLES2Impl::%s(%s) {\n" %
                (func.return_type, func.original_name,
                 func.MakeTypedOriginalArgString("")))
     extensions = ["CHROMIUM_sync_point", "CHROMIUM_texture_mailbox",
                   "CHROMIUM_sub_image", "CHROMIUM_miscellaneous",
-                  "occlusion_query_EXT"]
+                  "occlusion_query_EXT", "CHROMIUM_image",
+                  "CHROMIUM_copy_texture"]
     if func.IsCoreGLFunction() or func.GetInfo("extension") in extensions:
       file.Write("MojoGLES2MakeCurrent(context_);");
       func_return = "gl" + func.original_name + "(" + \
           func.MakeOriginalArgString("") + ");"
       if func.return_type == "void":
         file.Write(func_return);
       else:
         file.Write("return " + func_return);
     else:
       file.Write("NOTREACHED() << \"Unimplemented %s.\";\n" %
@@ skipping 5816 matching lines @@
   def WriteMojoGLES2Impl(self, filename):
     """Writes the Mojo GLES2 implementation."""
     file = CWriter(filename)
     file.Write(_LICENSE)
     file.Write(_DO_NOT_EDIT_WARNING)
 
     code = """
 #include "mojo/gpu/mojo_gles2_impl_autogen.h"
 
 #include "base/logging.h"
+#include "third_party/mojo/src/mojo/public/c/gles2/chromium_copy_texture.h"
+#include "third_party/mojo/src/mojo/public/c/gles2/chromium_image.h"
 #include "third_party/mojo/src/mojo/public/c/gles2/chromium_miscellaneous.h"
 #include "third_party/mojo/src/mojo/public/c/gles2/chromium_sub_image.h"
 #include "third_party/mojo/src/mojo/public/c/gles2/chromium_sync_point.h"
 #include "third_party/mojo/src/mojo/public/c/gles2/chromium_texture_mailbox.h"
 #include "third_party/mojo/src/mojo/public/c/gles2/gles2.h"
 #include "third_party/mojo/src/mojo/public/c/gles2/occlusion_query_ext.h"
 
 namespace mojo {
 
     """
@@ skipping 584 matching lines @@
       "CHROMIUM_sync_point")
   gen.WriteMojoGLCallVisitorForExtension(
       mojo_gles2_prefix + "_chromium_sub_image_autogen.h",
       "CHROMIUM_sub_image")
   gen.WriteMojoGLCallVisitorForExtension(
       mojo_gles2_prefix + "_chromium_miscellaneous_autogen.h",
       "CHROMIUM_miscellaneous")
   gen.WriteMojoGLCallVisitorForExtension(
       mojo_gles2_prefix + "_occlusion_query_ext_autogen.h",
       "occlusion_query_EXT")
+  gen.WriteMojoGLCallVisitorForExtension(
+      mojo_gles2_prefix + "_chromium_image_autogen.h",
+      "CHROMIUM_image")
+  gen.WriteMojoGLCallVisitorForExtension(
+      mojo_gles2_prefix + "_chromium_copy_texture_autogen.h",
+      "CHROMIUM_copy_texture")
 
   Format(gen.generated_cpp_filenames)
 
   if gen.errors > 0:
     print "%d errors" % gen.errors
     return 1
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))