test/cctest/test-heap.cc - Issue 1181013007: Debugger: require debugger to be active when dealing with breaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1181013007: Debugger: require debugger to be active when dealing with breaks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix yet another test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index e7d4f793614c79425f48301b8095de7d49c05688..c9d47757bf7cd820d208f07c699408255701dd97 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -1382,8 +1382,10 @@ TEST(TestCodeFlushingIncrementalAbort) {

// disabled.

int position = 0;

Handle<Object> breakpoint_object(Smi::FromInt(0), isolate);

+ EnableDebugger();

isolate->debug()->SetBreakPoint(function, breakpoint_object, &position);

isolate->debug()->ClearAllBreakPoints();

+ DisableDebugger();

// Force optimization now that code flushing is disabled.

{ v8::HandleScope scope(CcTest::isolate());

« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/mjsunit/debug-liveedit-breakpoints.js » ('j') | no next file with comments »