Use ArgumentError.value in more places in js_lib.

sdk/lib/_internal/compiler/js_lib/string_helper.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of _js_helper;
 
 stringIndexOfStringUnchecked(receiver, other, startIndex) {
   return JS('int', '#.indexOf(#, #)', receiver, other, startIndex);
 }
 
@@ skipping 127 matching lines @@
 String _matchString(Match match) => match[0];
 String _stringIdentity(String string) => string;
 
 stringReplaceAllFuncUnchecked(receiver, pattern, onMatch, onNonMatch) {
   if (onMatch == null) onMatch = _matchString;
   if (onNonMatch == null) onNonMatch = _stringIdentity;
   if (pattern is String) {
     return stringReplaceAllStringFuncUnchecked(receiver, pattern,
                                                onMatch, onNonMatch);
   }
-  // Pattern test here is indistingishable from at the top of the method but we
-  // don't need to do it on the `pattern is String` path.
+  // Placing the Pattern test here is indistingishable from placing it at the
+  // top of the method but it saves an extra check on the `pattern is String`
+  // path.
   if (pattern is! Pattern) {
-    throw new ArgumentError("${pattern} is not a Pattern");
+    throw new ArgumentError.value(pattern, 'pattern', 'is not a Pattern');
   }
   StringBuffer buffer = new StringBuffer();
   int startIndex = 0;
   for (Match match in pattern.allMatches(receiver)) {
     buffer.write(onNonMatch(receiver.substring(startIndex, match.start)));
     buffer.write(onMatch(match));
     startIndex = match.end;
   }
   buffer.write(onNonMatch(receiver.substring(startIndex)));
   return buffer.toString();
@@ skipping 80 matching lines @@
 stringJoinUnchecked(array, separator) {
   return JS('String', r'#.join(#)', array, separator);
 }
 
 String stringReplaceRangeUnchecked(String receiver,
                                    int start, int end, String replacement) {
   var prefix = JS('String', '#.substring(0, #)', receiver, start);
   var suffix = JS('String', '#.substring(#)', receiver, end);
   return "$prefix$replacement$suffix";
 }