Make browser tests all run from a server instead of the local filesystem.

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b751e6ce718df6a908c27bef6c31b14f5e0d7044..14dfcad86b27a6c313df7dac6a6d6c3216892bf2 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -20,6 +20,7 @@ import "dart:uri";
 import "status_file_parser.dart";
 import "test_progress.dart";
 import "test_suite.dart";
+import "http_server.dart" as http_server;
 
 const int NO_TIMEOUT = 0;
 const int SLOW_TIMEOUT_MULTIPLIER = 4;
@@ -179,25 +180,20 @@ class DumpRenderTreeCommand extends Command {
                         String htmlFile,
                         List<String> options,
                         List<String> dartFlags,
-                        Uri packageRootUri,

[Emily Fortuna, 2013/01/10 02:07:10]

Since all tests are being served via our server now, which deals with package
root issues on its own, this isn't being used.

(and package_root was never being propagated to Dartium proper)

                         io.Path this.expectedOutputPath)
       : super(executable,
               _getArguments(options, htmlFile),
-              _getEnvironment(dartFlags, packageRootUri));
+              _getEnvironment(dartFlags));
 
-  static Map _getEnvironment(List<String> dartFlags, Uri packageRootUri) {
+  static Map _getEnvironment(List<String> dartFlags) {
     var needDartFlags = dartFlags != null && dartFlags.length > 0;
-    var needDartPackageRoot = packageRootUri != null;
 
     var env = null;
-    if (needDartFlags || needDartPackageRoot) {
+    if (needDartFlags) {
       env = new Map.from(io.Platform.environment);
       if (needDartFlags) {
         env['DART_FLAGS'] = Strings.join(dartFlags, " ");
       }
-      if (needDartPackageRoot) {
-        env['DART_PACKAGE_ROOT'] = packageRootUri.toString();
-      }
     }
 
     return env;
@@ -1710,6 +1706,14 @@ class ProcessQueue {
       }
       if (_verbose) {
         int i = 1;
+        if (test is BrowserTestCase) {

[ricow1, 2013/01/10 20:03:41]

this is really useful, thanks

+          // Additional command for rerunning the steps locally after the fact.
+          print('$i. ${TestUtils.dartTestExecutable} '
+              '${TestUtils.dartDir()}/tools/testing/dart/http_server.dart '
+              '-p ${http_server.TestingServerRunner.serverList[0].port} '
+              '-c ${http_server.TestingServerRunner.serverList[1].port}');
+          i++;
+        }
         for (Command command in test.commands) {
           print('$i. ${command.commandLine}');
           i++;