third_party/yasm/README.skia - Issue 1180983002: Switch SkJpegCode to libjpeg-turbo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/yasm/README.skia

Issue 1180983002: Switch SkJpegCode to libjpeg-turbo (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Adding READMEs and comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 These platform specific Makefiles are necesary to build yasm on different platfo rms. The rest of

	6 the yasm is pulled into externals via the DEPS file. Chromium manually generate s these files, so
	scroggo 2015/06/23 15:05:51 nit: "the yasm library"? Or just "yasm"? "the yasm nit: "the yasm library"? Or just "yasm"? "the yasm" sounds funny to me (maybe if I knew what yasm stood for it would sound more natural). msarett 2015/06/23 17:47:43 Done. Show quoted text On 2015/06/23 15:05:51, scroggo wrote: > nit: "the yasm library"? Or just "yasm"? "the yasm" sounds funny to me (maybe if > I knew what yasm stood for it would sound more natural). Done.
	7 we will directly check in our own copies.
	scroggo 2015/06/23 15:05:51 Should we generate them, too? Why do we do somethi Should we generate them, too? Why do we do something different? msarett 2015/06/23 17:47:43 Sorry this is unclear. Chromium has manually gene Show quoted text On 2015/06/23 15:05:51, scroggo wrote: > Should we generate them, too? Why do we do something different? Sorry this is unclear. Chromium has manually generated these for all platforms and then checked them in. We are simply copying these from Chromium to avoid doing that work again.
OLD	NEW