platform_tools/android/third_party/jpeg/README.skia - Issue 1180983002: Switch SkJpegCode to libjpeg-turbo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: platform_tools/android/third_party/jpeg/README.skia

Issue 1180983002: Switch SkJpegCode to libjpeg-turbo (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Adding READMEs and comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 On Android, we pull in an outdated copy of libjpeg to platform_tools/third_party /externals/jpeg.
	scroggo 2015/06/23 15:05:51 Maybe instead of "an outdated copy of libjpeg", th Maybe instead of "an outdated copy of libjpeg", this should say that we pull in a copy with customizations that SkImageDecoder depends on? msarett 2015/06/23 17:47:43 Done. Show quoted text On 2015/06/23 15:05:51, scroggo wrote: > Maybe instead of "an outdated copy of libjpeg", this should say that we pull in > a copy with customizations that SkImageDecoder depends on? Done.
	2 We are in the process of updating to libjpeg-turbo, so briefly we will have a co py of both

	3 libraries checked in. We need to mangle the names of the libjpeg external APIs so that they do not

	4 conflict with the matching APIs from libjpeg-turbo. In order to do this, we use

	5 platform_tools/third_partyjpeg/manglejpeglib.h instead of the original

	6 platform_tools/third_party/externals/jpeg/jpeglib.h file.

OLD	NEW