sdk/lib/_internal/compiler/js_lib/js_rti.dart - Issue 1180973003: dart2js cps: Support function types in 'is' and 'as' operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_rti.dart

Issue 1180973003: dart2js cps: Support function types in 'is' and 'as' operators. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update doc comment for TypeCast Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/js_lib/js_rti.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_rti.dart b/sdk/lib/_internal/compiler/js_lib/js_rti.dart

index f1531501070267101dc1ecb65b3443f12d4b375a..e5669e2a6babfca6dfcb3b2d8269714294549f74 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_rti.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_rti.dart

@@ -389,7 +389,8 @@ bool checkSubtypeOfRuntimeType(o, t) {

rti = JS('JSExtendableArray', '#.slice()', rti); // Make a copy.

JS('', '#.splice(0, 0, #)', rti, type); // Insert type at position 0.

type = rti;

- } else if (isDartFunctionType(t)) {

+ }

+ if (isDartFunctionType(t)) {

// Functions are treated specially and have their type information stored

// directly in the instance.

var targetSignatureFunction =

« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »