Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1180973003: dart2js cps: Support function types in 'is' and 'as' operators. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix status file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
index 33ddf42ae34e5a423820f10242101cb3cd582983..06f034c4b7c273f90305be88de85b95a2ac9058f 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
@@ -364,7 +364,7 @@ class InvokeConstructor extends Expression implements Invoke {
/// An "is" type test.
///
-/// Returns `true` if [value] not `null` and is an instance of [type].
+/// Returns `true` if [value] is an instance of [type].
///
/// [type] must not be the [Object], `dynamic` or [Null] types (though it might
/// be a type variable containing one of these types). This design is chosen
@@ -380,6 +380,9 @@ class TypeTest extends Primitive {
/// If [type] is a [TypeVariableType], this is a singleton list with
/// the internal representation of the type held in that type variable.
///
+ /// If [type] is a [FunctionType], this is a singleton list with the
+ /// internal representation of that type,
+ ///
/// Otherwise the list is empty.
final List<Reference<Primitive>> typeArguments;
karlklose 2015/06/18 07:45:02 We should rename this field. How about 'typeRepre
asgerf 2015/06/18 09:20:38 Well, at least now it makes sense for the Interfac

Powered by Google App Engine
This is Rietveld 408576698