src/preparser.cc - Issue 1180943007: [strong] Make strong 'this' optional for experimentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.cc

Issue 1180943007: [strong] Make strong 'this' optional for experimentation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.cc

diff --git a/src/preparser.cc b/src/preparser.cc

index ddea1792781a5d10310b2095b9c67e7dff9531f2..42703d6ddfc357838641521e74cce906678e0b16 100644

--- a/src/preparser.cc

+++ b/src/preparser.cc

@@ -600,7 +600,8 @@ PreParser::Statement PreParser::ParseExpressionOrLabelledStatement(bool* ok) {

case Token::THIS:

case Token::SUPER:

- if (is_strong(language_mode()) &&

+ if ((FLAG_strong_this || peek() != Token::THIS) &&

conradw 2015/06/12 15:04:58 Similar here (sorry for spam)

rossberg 2015/06/15 08:50:30 Done.

+ is_strong(language_mode()) &&

i::IsConstructor(function_state_->kind())) {

bool is_this = peek() == Token::THIS;

Expression expr = Expression::Default();

« src/parser.cc ('K') | « src/preparser.h ('k') | no next file » | no next file with comments »